Re: btrfs_inode_item's otime?

[David Sterba <dsterba@suse.cz>]

On Fri, Jan 09, 2015 at 05:11:42PM +0100, David Sterba wrote:
> > --- a/fs/btrfs/inode.c
> > +++ b/fs/btrfs/inode.c
> > @@ -5835,6 +5835,11 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
> >                              sizeof(*inode_item));
> >         fill_inode_item(trans, path->nodes[0], inode_item, inode);
> >  
> > +       /*
> > +        * Set the creation time on the inode.
> > +        */
> > +       btrfs_set_stack_timespec_sec( &inode.otime, cur_time.tv_sec );
> 
> Drop the spaces after/before parens and also set usec the same way.
> There's no such thing as 'current_time', only CURRENT_TIME but that
> cannot be used directly as a structure.
> 
> Given that the mtime is set a few lines above, copy the tv_sec and
> tv_usec from there.

chandan pointed out on IRC the other day that he'd sent a patch for that
already

http://www.mail-archive.com/linux-btrfs%40vger.kernel.org/msg17508.html

Though the patch cannot be applied as-is, it's more complete (I've
missed a few places where the otime has to be set).

Chandan, please drop the btrfs_inode_otime helper and resend. Thanks.