From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH 04/11] x86/MM: Improve p2m type checks. Date: Thu, 15 Jan 2015 17:36:24 +0100 Message-ID: <20150115163624.GD57240@deinos.phlegethon.org> References: <1420838801-11704-1-git-send-email-edmund.h.white@intel.com> <1420838801-11704-5-git-send-email-edmund.h.white@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1420838801-11704-5-git-send-email-edmund.h.white@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ed White Cc: keir@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi, At 13:26 -0800 on 09 Jan (1420806394), Ed White wrote: > The alternate p2m code will introduce a new p2m type. In preparation for using > that new type, introduce the type indicator here and fix all the checks > that assume !nestedp2m == hostp2m to explicitly check for hostp2m. > > Signed-off-by: Ed White This looks like a good idea regardless of altp2m. If you move the altp2m bits out (into patch #5, I think), I'll just check this in. Maybe also s/p2m type/p2m class/ to avoid confusion with p2m_type_*. Cheers, Tim.