From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC0O6-0004th-N6 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 01:28:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC0O4-0005CL-1d for qemu-devel@nongnu.org; Fri, 16 Jan 2015 01:28:06 -0500 Date: Fri, 16 Jan 2015 17:21:55 +1100 From: David Gibson Message-ID: <20150116062155.GK5297@voom.fritz.box> References: <1419337831-16552-1-git-send-email-mdroth@linux.vnet.ibm.com> <1419337831-16552-4-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hdW7zL/qDS6RXdAL" Content-Disposition: inline In-Reply-To: <1419337831-16552-4-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --hdW7zL/qDS6RXdAL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2014 at 06:30:17AM -0600, Michael Roth wrote: > From: Nathan Fontenot >=20 > Signed-off-by: Nathan Fontenot > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_rtas.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) >=20 > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index 2ec2a8e..a2fb533 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -290,6 +290,27 @@ static void rtas_ibm_os_term(PowerPCCPU *cpu, > rtas_st(rets, 0, ret); > } > =20 > +static void rtas_set_power_level(PowerPCCPU *cpu, sPAPREnvironment *spap= r, > + uint32_t token, uint32_t nargs, > + target_ulong args, uint32_t nret, > + target_ulong rets) > +{ > + /* we currently only use a single, "live insert" powerdomain for > + * hotplugged/dlpar'd resources, so the power is always live/full (1= 00) > + */ Even so, you should at least validate the number of args and rets, and preferably check that the user isn't attempt to set something for some other, non-existent power domain. > + rtas_st(rets, 0, RTAS_OUT_SUCCESS); > + rtas_st(rets, 1, 100); > +} > + > +static void rtas_get_power_level(PowerPCCPU *cpu, sPAPREnvironment *spap= r, > + uint32_t token, uint32_t nargs, > + target_ulong args, uint32_t nret, > + target_ulong rets) > +{ > + rtas_st(rets, 0, RTAS_OUT_SUCCESS); > + rtas_st(rets, 1, 100); > +} > + > static struct rtas_call { > const char *name; > spapr_rtas_fn fn; > @@ -419,6 +440,10 @@ static void core_rtas_register_types(void) > rtas_ibm_set_system_parameter); > spapr_rtas_register(RTAS_IBM_OS_TERM, "ibm,os-term", > rtas_ibm_os_term); > + spapr_rtas_register(RTAS_SET_POWER_LEVEL, "set-power-level", > + rtas_set_power_level); > + spapr_rtas_register(RTAS_GET_POWER_LEVEL, "get-power-level", > + rtas_get_power_level); > } > =20 > type_init(core_rtas_register_types) This code should probably go in spapr_drc.c. The idea that spapr_rtas was just the RTAS dispatch code, and RTAS functions that had no other home. Generally RTAS functions should live with the devices they're connected to. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --hdW7zL/qDS6RXdAL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUuK4DAAoJEGw4ysog2bOShpgQANT2YXRiDdjqulwyPVNCfVUl CjGH/huCAHNoigfiZaAQmvSwh+RjTyowoKeYphkPJyeC3vOATH7GRWtJC0LuOfTR kbZVhs7lr+9mwbm/ky9bsf7GQrojioZXP3qXWd3fe+wcmA57KB0LxG7Ci0ItPZI3 QVFXIAA6PaW7Ci5ZWKdrYyqYZOGR2dHFzwdmC8Da+nrFWbDQZh2EL2eVGaGQBf3N bYv0sr/1TiRrSb3aADZg9WAx1fXeQGvd44B5jHISmijYy5UlfGcs3m6oHLeOMyec LkJ2JiEpvRmPc/HNvwkv1vNuWmWXGWE1kAi5pZunn4E1DmLWRpNMV5uFXLHST2Xe KJKnFNh+8MFHdpApHmjwBr64a/fWrcGUhs82BbSR6wJWuSG1KK0pKOEwXMx31ybe 68ovTRUWxNvk/qweb2LQSKm85UJuSpS1NpHMJ7uJuziK5dUSPnW7O1lckWHTWgX8 l7GjlHhFssByiw2GrZM5OVuFdqNVZG9kaIhSm51pwqnuWRmza/W6n5fqvLoIziHN 6m1+yJ5aNZiALGDRfeTmRfuSkHMoh6Q5mOudywVzbPJ/R+9jJAUUOLjvQltuxG/+ YYJCkknHDz6n942dnwwCj88OgTMxdg7UYg+XrVJvR9iT6lVoxtUjVQ5qtzYp7YBL u64+n+zrS9gzLI9Ln1ce =8Lpr -----END PGP SIGNATURE----- --hdW7zL/qDS6RXdAL--