All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Keir Fraser <keir@xen.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] re-order struct domain fields
Date: Mon, 19 Jan 2015 17:00:26 +0100	[thread overview]
Message-ID: <20150119160026.GF17236@deinos.phlegethon.org> (raw)
In-Reply-To: <54BD340602000078000568FB@mail.emea.novell.com>

At 15:42 +0000 on 19 Jan (1421678566), Jan Beulich wrote:
> ... to reduce padding holes.
> 
> I also wonder whether having independent spin locks side by side is
> really a good thing cache-line-bouncing-wise.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

> @@ -390,15 +397,12 @@ struct domain
>  
>      /* If this is not 0, send suspend notification here instead of
>       * raising DOM_EXC */
> -    int              suspend_evtchn;
> +    evtchn_port_t    suspend_evtchn;
>  

This type change looks OK, but please mention it in the cset
description.

Acked-by: Tim Deegan <tim@xen.org>

Cheers,

Tim.

  reply	other threads:[~2015-01-19 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 15:42 [PATCH] re-order struct domain fields Jan Beulich
2015-01-19 16:00 ` Tim Deegan [this message]
2015-01-19 16:25 ` Ian Campbell
2015-01-19 16:35   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150119160026.GF17236@deinos.phlegethon.org \
    --to=tim@xen.org \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.