From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:11569 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011481AbbASQj4cm6Gg (ORCPT ); Mon, 19 Jan 2015 17:39:56 +0100 Message-ID: <54BD3355.9010104@imgtec.com> Date: Mon, 19 Jan 2015 16:39:49 +0000 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH RFC v2 12/70] MIPS: asm: asmmacro: Replace add instructions with "addui" References: <1421405389-15512-1-git-send-email-markos.chandras@imgtec.com> <1421405389-15512-13-git-send-email-markos.chandras@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: "Maciej W. Rozycki" Cc: linux-mips@linux-mips.org Message-ID: <20150119163949.G_HaXuZRgnXZPrB1RYhls-syqsii1_8TxDzAR52LJF4@z> On 01/19/2015 03:59 PM, Maciej W. Rozycki wrote: > On Fri, 16 Jan 2015, Markos Chandras wrote: > >> The use of "add" instruction for immediate operations can result to >> build failures for MIPS R6. This is because, the 'add' is a macro in >> binutils and depending on the size of the immediate it can expand to >> an 'addi' instruction which has been removed from MIPS R6. >> Thus, we will be using the 'addu' macro instead, which also >> accepts immediate operands. >> >> Link: http://www.linux-mips.org/archives/linux-mips/2015-01/msg00121.html >> Cc: Maciej W. Rozycki >> Signed-off-by: Markos Chandras >> --- > > This needs a title fix: s/addui/addu/; I'd suggest making the use of > quotation marks consistent too on this occasion, e.g.: > > MIPS: asm: asmmacro: Replace "add" instructions with "addu" > > You might take the opportunity to decide on single or double quotes > throughout the description too; right now it looks a bit messy to me. > > Other than that -- this is self-contained and an actual bug fix, > irrelevant to R6. I think it can and really should go in right away > regardless of the outcome of the discussion on the other changes in this > series. Also to any stable branches where applicable; the change is so > obvious that it cannot do any harm. > > So please resend this change with the title fix (and any description > updates), and I'll give you my review acceptance tag to speed up > processing. > > NB it looks to me like a followup change is needed to ensure the correct > operation of these macros in 64-bit kernels, where a doubleword addition > must be used instead for address calculation. One way would be by using > the PTR_ADDU preprocessor macro, but there are other possibilities as > well. This is not a requirement for this change to be accepted as far as > I am concerned though. > > Thanks, > > Maciej > sorry i might be missing something but why do you think this is an important bug fix that should go into 3.19? the way i read the code it seems that it can't go wrong at the moment. -- markos