From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDG6Z-000748-3i for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:27:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDG6Y-0004fG-4P for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:27:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDG6X-0004eu-T4 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:27:10 -0500 Date: Mon, 19 Jan 2015 18:26:54 +0100 From: Igor Mammedov Message-ID: <20150119182654.5742ab2c@nial.brq.redhat.com> In-Reply-To: <1420613385-13679-3-git-send-email-tangchen@cn.fujitsu.com> References: <1420613385-13679-1-git-send-email-tangchen@cn.fujitsu.com> <1420613385-13679-3-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v1 2/5] acpi, ich9: Add hotunplug request cb for ich9. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tang Chen Cc: zhugh.fnst@cn.fujitsu.com, mst@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com, pbonzini@redhat.com On Wed, 7 Jan 2015 14:49:42 +0800 Tang Chen wrote: > Memory and CPU hot unplug are both asynchronize procedures. s/asynchronize/asynchronous/ > They both need unplug request cb when the unplug operation happens. > > This patch adds hotunplug request cb for ich9, and memory and CPU > hot unplug will base on it. s/base on it/share it/ > --- > hw/acpi/ich9.c | 7 +++++++ > hw/isa/lpc_ich9.c | 5 +++-- > include/hw/acpi/ich9.h | 2 ++ > 3 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index ea991a3..5ce3aaf 100644 > --- a/hw/acpi/ich9.c > +++ b/hw/acpi/ich9.c > @@ -301,6 +301,13 @@ void ich9_pm_device_plug_cb(ICH9LPCPMRegs *pm, DeviceState *dev, Error **errp) > } > } > > +void ich9_pm_device_unplug_request_cb(ICH9LPCPMRegs *pm, DeviceState *dev, > + Error **errp) > +{ > + error_setg(errp, "acpi: device unplug request for not supported device" > + " type: %s", object_get_typename(OBJECT(dev))); > +} > + > void ich9_pm_ospm_status(AcpiDeviceIf *adev, ACPIOSTInfoList ***list) > { > ICH9LPCState *s = ICH9_LPC_DEVICE(adev); > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c > index 530b074..d00b223 100644 > --- a/hw/isa/lpc_ich9.c > +++ b/hw/isa/lpc_ich9.c > @@ -610,8 +610,9 @@ static void ich9_device_plug_cb(HotplugHandler *hotplug_dev, > static void ich9_device_unplug_request_cb(HotplugHandler *hotplug_dev, > DeviceState *dev, Error **errp) > { > - error_setg(errp, "acpi: device unplug request for not supported device" > - " type: %s", object_get_typename(OBJECT(dev))); > + ICH9LPCState *lpc = ICH9_LPC_DEVICE(hotplug_dev); > + > + ich9_pm_device_unplug_request_cb(&lpc->pm, dev, errp); > } > > static bool ich9_rst_cnt_needed(void *opaque) > diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h > index fe975e6..86853c3 100644 > --- a/include/hw/acpi/ich9.h > +++ b/include/hw/acpi/ich9.h > @@ -59,6 +59,8 @@ extern const VMStateDescription vmstate_ich9_pm; > void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm, Error **errp); > > void ich9_pm_device_plug_cb(ICH9LPCPMRegs *pm, DeviceState *dev, Error **errp); > +void ich9_pm_device_unplug_request_cb(ICH9LPCPMRegs *pm, DeviceState *dev, > + Error **errp); > > void ich9_pm_ospm_status(AcpiDeviceIf *adev, ACPIOSTInfoList ***list); > #endif /* HW_ACPI_ICH9_H */