From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: zhugh.fnst@cn.fujitsu.com, hutao@cn.fujitsu.com,
qemu-devel@nongnu.org, Tang Chen <tangchen@cn.fujitsu.com>,
isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug.
Date: Tue, 20 Jan 2015 12:40:22 +0200 [thread overview]
Message-ID: <20150120104022.GB26442@redhat.com> (raw)
In-Reply-To: <20150120110302.64dfcde3@nial.brq.redhat.com>
On Tue, Jan 20, 2015 at 11:03:02AM +0100, Igor Mammedov wrote:
> On Mon, 19 Jan 2015 23:29:37 +0200
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Wed, Jan 07, 2015 at 02:49:40PM +0800, Tang Chen wrote:
> > > Memory and CPU hot unplug are both asynchronize procedures.
> > > When the unplug operation happens, unplug request cb is called first.
> > > And when ghest OS finished handling unplug, unplug cb will be called
> > > to do the real removal of device.
> > >
> > > They both need pc-machine, piix4 and ich9 unplug and unplug request cb.
> > > So this patch set introduces these commom functions as part1, and memory
> > > and CPU hot-unplug will come soon as part 2 and 3.
> > >
> > > This patch-set is based on QEmu 2.2
> >
> > OK, Igor - you only have comments for the commit log?
> > I take this as implicit ack of the patches?
> > If so pls let me know.
> Yes, patches themselves are good.
> Can fixup commit messages and add author SoBs to them, before
> applying or should we wait for respin?
I didn't notice signatures were missing.
This is required for inclusion.
Tang Chen, please rebase on top of my pci branch, but also,
we don't include code of uncertain origin.
So - if you can certify the below:
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
then you add a line at the end of each commit message saying
Signed-off-by: Random J Developer <random@developer.example.org>
for each developer who participated in writing this code.
>
> > > Tang Chen (5):
> > > acpi, pc: Add hotunplug request cb for pc machine.
> > > acpi, ich9: Add hotunplug request cb for ich9.
> > > acpi, pc: Add unplug cb for pc machine.
> > > acpi, ich9: Add unplug cb for ich9.
> > > acpi, piix4: Add unplug cb for piix4.
> > >
> > > hw/acpi/ich9.c | 14 ++++++++++++++
> > > hw/acpi/piix4.c | 8 ++++++++
> > > hw/i386/pc.c | 16 ++++++++++++++++
> > > hw/isa/lpc_ich9.c | 14 ++++++++++++--
> > > include/hw/acpi/ich9.h | 4 ++++
> > > 5 files changed, 54 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 1.8.4.2
prev parent reply other threads:[~2015-01-20 10:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 6:49 [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug Tang Chen
2015-01-07 6:49 ` [Qemu-devel] [RESEND PATCH v1 1/5] acpi, pc: Add hotunplug request cb for pc machine Tang Chen
2015-01-07 6:49 ` [Qemu-devel] [RESEND PATCH v1 2/5] acpi, ich9: Add hotunplug request cb for ich9 Tang Chen
2015-01-19 17:26 ` Igor Mammedov
2015-01-07 6:49 ` [Qemu-devel] [RESEND PATCH v1 3/5] acpi, pc: Add unplug cb for pc machine Tang Chen
2015-01-19 17:29 ` Igor Mammedov
2015-01-07 6:49 ` [Qemu-devel] [RESEND PATCH v1 4/5] acpi, ich9: Add unplug cb for ich9 Tang Chen
2015-01-19 17:34 ` Igor Mammedov
2015-01-07 6:49 ` [Qemu-devel] [RESEND PATCH v1 5/5] acpi, piix4: Add unplug cb for piix4 Tang Chen
2015-01-19 17:37 ` Igor Mammedov
2015-01-19 17:40 ` [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug Igor Mammedov
2015-01-19 21:29 ` Michael S. Tsirkin
2015-01-20 10:03 ` Igor Mammedov
2015-01-20 10:40 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120104022.GB26442@redhat.com \
--to=mst@redhat.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hutao@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tangchen@cn.fujitsu.com \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.