All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Pawel Moll <pawel.moll@arm.com>
Cc: "virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>
Subject: Re: [RFC] virtio-mmio: Update the device to OASIS spec version
Date: Tue, 20 Jan 2015 19:56:30 +0200	[thread overview]
Message-ID: <20150120175630.GB2706@redhat.com> (raw)
In-Reply-To: <1421776271.14076.21.camel@arm.com>

On Tue, Jan 20, 2015 at 05:51:11PM +0000, Pawel Moll wrote:
> On Tue, 2015-01-20 at 17:44 +0000, Michael S. Tsirkin wrote:
> > Good. But your current code will also try to support a mix: device that
> > uses the new transport underneath, but old layout and semantics on top.
> 
> It will not try to support the mix, but rather will not stop it from
> working.
>
> > This has no value: the spec does *not* define such devices
> > and it also does not match any hosts, so this just adds to support matrix.
> > And if linux supports it, someone *will* ship such a
> > device and we'll be stuck with it forever.
> >
> > So please, detect out of spec devices and fail gracefully.
> > pci and s390 do this already.
> 
> Ok, let it be. Will send v2 in a second.
> 
> Pawel

Thanks!
The relevant functions are finalize_features
(to check feature bit) and probe (to check is_legacy).

-- 
MST

  reply	other threads:[~2015-01-20 17:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 18:38 [RFC] virtio-mmio: Update the device to OASIS spec version Pawel Moll
2015-01-15 16:51 ` Michael S. Tsirkin
2015-01-15 17:12   ` Michael S. Tsirkin
2015-01-15 17:15     ` Pawel Moll
2015-01-15 17:19       ` Michael S. Tsirkin
2015-01-16  9:58         ` Cornelia Huck
2015-01-15 17:32   ` Pawel Moll
2015-01-15 17:51     ` Michael S. Tsirkin
2015-01-15 18:11       ` Pawel Moll
2015-01-15 18:29         ` Michael S. Tsirkin
2015-01-15 18:42           ` Pawel Moll
2015-01-15 19:12             ` Michael S. Tsirkin
2015-01-19 17:45               ` Pawel Moll
2015-01-19 18:36                 ` Michael S. Tsirkin
2015-01-20 17:18                   ` Pawel Moll
2015-01-20 17:44                     ` Michael S. Tsirkin
2015-01-20 17:51                       ` Pawel Moll
2015-01-20 17:56                         ` Michael S. Tsirkin [this message]
2015-01-15 18:17       ` Michael S. Tsirkin
2015-01-15 18:39 ` Michael S. Tsirkin
2015-01-15 18:51   ` Pawel Moll
2015-01-15 19:12     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120175630.GB2706@redhat.com \
    --to=mst@redhat.com \
    --cc=pawel.moll@arm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.