From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 22 Jan 2015 00:36:15 +0100
Subject: [U-Boot] [PATCH 5/5] Add support for ReachTech G2C1 board
In-Reply-To: <1421841318-3014-6-git-send-email-gruss@tss-engineering.com>
References: <1421841318-3014-1-git-send-email-gruss@tss-engineering.com>
	<1421841318-3014-6-git-send-email-gruss@tss-engineering.com>
Message-ID: <201501220036.15576.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, January 21, 2015 at 12:55:18 PM, Graeme Russ wrote:
> Signed-off-by: Graeme Russ <gruss@tss-engineering.com>

Commit message again ;-)

[...]

> diff --git a/board/reachtech/g2c1/g2c1.c b/board/reachtech/g2c1/g2c1.c
> new file mode 100644
> index 0000000..5bf437d
> --- /dev/null
> +++ b/board/reachtech/g2c1/g2c1.c
> @@ -0,0 +1,79 @@

[...]

> +#ifdef CONFIG_CMD_MMC
> +
> +int board_mmc_init(bd_t *bis)
> +{
> +	return mxsmmc_initialize(bis, 0, NULL /* g2c1_mmc_wp */, NULL);

Where's the WP function?

> +}
> +#endif
> diff --git a/board/reachtech/g2c1/spl_boot.c
> b/board/reachtech/g2c1/spl_boot.c new file mode 100644
> index 0000000..25ee0e2
> --- /dev/null
> +++ b/board/reachtech/g2c1/spl_boot.c
> @@ -0,0 +1,452 @@
> +/*
> + * DENX M28 Boot setup
> + *
> + * Copyright (C) 2011 Marek Vasut <marek.vasut@gmail.com>
> + * on behalf of DENX Software Engineering GmbH
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <config.h>
> +#include <asm/io.h>
> +#include <asm/arch/iomux-mx28.h>
> +#include <asm/arch/imx-regs.h>
> +#include <asm/arch/sys_proto.h>
> +
> +/*
> + *	Bank.	SoC
> + *	Pin	Pin	Function	Comments

All this stuff should be in some README instead .

[...]

> +#define CONFIG_EXTRA_ENV_SETTINGS					\
> +	"consdev=ttyAMA0\0"						\
> +	"baudrate=115200\0"						\
> +	"bootscript=boot.scr\0"						\
> +	"bootdev=/dev/mmcblk0p2\0"					\
> +	"rootdev=/dev/mmcblk0p3\0"					\
> +	"netdev=eth0\0"							\
> +	"hostname=g2c1\0"						\
> +	"rootpath=/opt/eldk-5.5/armv5te/rootfs-qte-sdk\0"		\

Remove this rootpath var from here.

Thanks!