From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Peng Subject: Re: [PATCH v5 0/6] enable Memory Bandwidth Monitoring (MBM) for VMs Date: Thu, 22 Jan 2015 09:12:10 +0800 Message-ID: <20150122011210.GB28428@pengc-linux.bj.intel.com> References: <1421839164-26037-1-git-send-email-chao.p.peng@linux.intel.com> <54BF9B7202000078000579DA@mail.emea.novell.com> Reply-To: Chao Peng Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <54BF9B7202000078000579DA@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Jan 21, 2015 at 11:28:34AM +0000, Jan Beulich wrote: > >>> On 21.01.15 at 12:19, wrote: > > Changes from v4: > > * Make the counter read and timestamp read atomic by disable IRQ; > > * Treat MSR_IA32_TSC as a special case and return NOW() for read path; > > * Add MBM description in xl command line. > > You should really have answered Andrew's question regarding the > use of NOW() vs RDTSC before posting this new series. As I have adopted it so I agree with Andrew's suggestion. NOW() is much fullfill my requirement. But perhaps not so semantic consistent with MSR_IA32_TSC? > > You should also see to correct the Cc list of your postings - neither > should all patches always have the same set of people Cc-ed, nor > should you be missing to Cc maintainers of the code you modify. > Yeah, seems Andrew is the one I missed. CCed now. Chao