From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Thu, 22 Jan 2015 11:19:12 +0800
From: Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 55/69] staging: unisys: get rid of LOGWRN() macro and
 uisklog.h
Message-ID: <20150122031912.GB16561@kroah.com>
References: <1417817384-3811-1-git-send-email-benjamin.romer@unisys.com>
 <1417817384-3811-56-git-send-email-benjamin.romer@unisys.com>
 <20150110014022.GD17555@kroah.com>
 <C97001BC43954D438ACB059713BA5CDFDBF1A0CD73@USEA-EXCH7.na.uis.unisys.com>
 <20150121155331.GJ6456@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150121155331.GJ6456@mwanda>
List-ID: <driverdev-devel.linuxdriverproject.org>
To: "Romer, Benjamin M" <Benjamin.Romer@unisys.com>, *S-Par-Maintainer <SParMaintainer@unisys.com>, "driverdev-devel@linuxdriverproject.org" <driverdev-devel@linuxdriverproject.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>

On Wed, Jan 21, 2015 at 06:53:31PM +0300, Dan Carpenter wrote:
> Generally "delete code" patches are easy to review.  But sometimes you
> have to change formatting and remove variables and curly braces.
> 
> $ grep LOG drivers/staging/unisys/ -R | wc -l
> 415
> 
> There isn't a firm rule on way a patch is just too big and annoying to
> review.  Probably break it up into:
> 
> [patch 1/x] delete LOGINF()
> [patch 2/x] delete LOGERR()
> ...

Yes, this would be best.

Always remember, what would you like to have to review if you were the
receiver of patches?

thanks,

greg k-h