From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEDUb-0000UQ-Jq for qemu-devel@nongnu.org; Thu, 22 Jan 2015 03:51:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEDUa-00052w-H7 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 03:51:57 -0500 Received: from mail.ispras.ru ([83.149.199.45]:36307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEDUa-00052Q-AN for qemu-devel@nongnu.org; Thu, 22 Jan 2015 03:51:56 -0500 From: Pavel Dovgalyuk Date: Thu, 22 Jan 2015 11:51:59 +0300 Message-ID: <20150122085158.5276.29044.stgit@PASHA-ISP.def.inno> In-Reply-To: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC PATCH v8 05/21] replay: introduce mutex to protect the replay log List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, afaerber@suse.de, fred.konrad@greensocs.com This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c | 25 +++++++++++++++++++++++++ replay/replay-internal.h | 7 +++++++ 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/replay/replay-internal.c b/replay/replay-internal.c index 3865fa5..f552dad 100755 --- a/replay/replay-internal.c +++ b/replay/replay-internal.c @@ -15,6 +15,11 @@ unsigned int replay_data_kind = -1; unsigned int replay_has_unread_data; +/* Mutex to protect reading and writing events to the log. + replay_data_kind and replay_has_unread_data are also protected + by this mutex. */ +static QemuMutex lock; + /* File for replay writing */ FILE *replay_file; @@ -139,3 +144,23 @@ void replay_fetch_data_kind(void) } } } + +void replay_mutex_init(void) +{ + qemu_mutex_init(&lock); +} + +void replay_mutex_destroy(void) +{ + qemu_mutex_destroy(&lock); +} + +void replay_mutex_lock(void) +{ + qemu_mutex_lock(&lock); +} + +void replay_mutex_unlock(void) +{ + qemu_mutex_unlock(&lock); +} diff --git a/replay/replay-internal.h b/replay/replay-internal.h index dad5bc8..50ce29b 100755 --- a/replay/replay-internal.h +++ b/replay/replay-internal.h @@ -34,6 +34,13 @@ int64_t replay_get_qword(void); void replay_get_array(uint8_t *buf, size_t *size); void replay_get_array_alloc(uint8_t **buf, size_t *size); +/* Mutex functions for protecting replay log file */ + +void replay_mutex_init(void); +void replay_mutex_destroy(void); +void replay_mutex_lock(void); +void replay_mutex_unlock(void); + /*! Checks error status of the file. */ void replay_check_error(void);