From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chao Peng <chao.p.peng@linux.intel.com>
Subject: Re: [PATCH v5 0/6] enable Memory Bandwidth Monitoring
 (MBM) for VMs
Date: Thu, 22 Jan 2015 18:36:54 +0800
Message-ID: <20150122103654.GC28428@pengc-linux.bj.intel.com>
References: <1421839164-26037-1-git-send-email-chao.p.peng@linux.intel.com>
	<54BF9B7202000078000579DA@mail.emea.novell.com>
	<20150122011210.GB28428@pengc-linux.bj.intel.com>
	<54C0BBFB0200007800057F60@mail.emea.novell.com>
Reply-To: Chao Peng <chao.p.peng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <54C0BBFB0200007800057F60@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, will.auld@intel.com, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Jan 22, 2015 at 07:59:39AM +0000, Jan Beulich wrote:
> >>> On 22.01.15 at 02:12, <chao.p.peng@linux.intel.com> wrote:
> > On Wed, Jan 21, 2015 at 11:28:34AM +0000, Jan Beulich wrote:
> >> >>> On 21.01.15 at 12:19, <chao.p.peng@linux.intel.com> wrote:
> >> > Changes from v4:
> >> > * Make the counter read and timestamp read atomic by disable IRQ;
> >> > * Treat MSR_IA32_TSC as a special case and return NOW() for read path;
> >> > * Add MBM description in xl command line.
> >> 
> >> You should really have answered Andrew's question regarding the
> >> use of NOW() vs RDTSC before posting this new series.
> > 
> > As I have adopted it so I agree with Andrew's suggestion. NOW() is much
> > fullfill my requirement. But perhaps not so semantic consistent with
> > MSR_IA32_TSC?
> 
> Exactly - I didn't look at the patch itself yet, but at the very least
> this would need to be very clearly documented in the public header.

No problem. Or it's our time to create "XEN_RESOURCE_OP_SYSTIME_READ"
sub-op to omit adding such specific comment in platform.h?

Chao
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel