All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Yijing Wang <wangyijing@huawei.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Jiang Liu" <jiang.liu@linux.intel.com>,
	linux-pci@vger.kernel.org, "Yinghai Lu" <yinghai@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Marc Zyngier" <marc.zyngier@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	"Russell King" <linux@arm.linux.org.uk>,
	x86@kernel.org, "Thomas Gleixner" <tglx@linutronix.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Rusty Russell" <rusty@rustcorp.com.au>,
	"Tony Luck" <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	"Guan Xuetao" <gxt@mprc.pku.edu.cn>,
	linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	"Liviu Dudau" <liviu@dudau.co.uk>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Gregory Clément" <gregory.clement@free-electrons.com>
Subject: Re: [PATCH v2 23/30] PCI/mvebu: Use pci_common_init_dev() to simplify code
Date: Thu, 22 Jan 2015 18:40:00 +0100	[thread overview]
Message-ID: <20150122184000.63ba06bb__12904.9051939093$1421948438$gmane$org@free-electrons.com> (raw)
In-Reply-To: <1421800225-26230-24-git-send-email-wangyijing@huawei.com>

Dear Yijing Wang,

On Wed, 21 Jan 2015 08:30:18 +0800, Yijing Wang wrote:
> Mvebu_pcie_scan_bus() is not necessary, we could use
> pci_common_init_dev() instead of pci_common_init(),
> and pass the device pointer as the parent. Then
> pci_scan_root_bus() will be called to scan the pci busses.
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> CC: Jason Cooper <jason@lakedaemon.net>

While I'm fine with the change to pci_common_init_dev(), I am not so
sure about the removal of mvebu_pcie_scan_bus(). I vaguely remember
that we intentionally did not use the default function for a specific
reason. Of course, this was a long time ago, and I don't remember the
reason. I would have to take a bit of time to 1/ review the archives of
the discussion surrounding the pcie-mvebu driver, and 2/ test your
patch to validate it works fine on HW.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-01-22 17:40 UTC|newest]

Thread overview: 267+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  0:29 [PATCH v2 00/30] Refine PCI scan interfaces and make generic pci host bridge Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29 ` [PATCH v2 01/30] PCI: Rip out pci_bus_add_devices() from pci_scan_bus() Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29 ` [PATCH v2 02/30] PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus() Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29 ` [PATCH v2 03/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented() Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-22 20:25   ` Konrad Rzeszutek Wilk
2015-01-22 20:25   ` Konrad Rzeszutek Wilk
2015-01-22 20:25     ` Konrad Rzeszutek Wilk
2015-01-22 20:25     ` Konrad Rzeszutek Wilk
2015-01-23  2:12     ` Yijing Wang
2015-01-23  2:12       ` Yijing Wang
2015-01-23  2:12       ` Yijing Wang
2015-01-23  2:12       ` Yijing Wang
2015-01-23  2:12     ` Yijing Wang
2015-01-21  0:29 ` [PATCH v2 04/30] PCI: Remove deprecated pci_scan_bus_parented() Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29   ` Yijing Wang
2015-01-21  0:29 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 05/30] PCI: Rename pci_scan_bus() to pci_scan_bus_legacy() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 06/30] PCI: Combine PCI domain and bus number in u32 arg Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 07/30] PCI: Pass PCI domain number combined with root bus number Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 10/30] PCI: Introduce pci_host_bridge_list to manage host bridges Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 11/30] PCI: Save sysdata in pci_host_bridge drvdata Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 12/30] PCI: Introduce pci_host_bridge_ops to support host specific operations Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 13/30] PCI: Introduce new scan function pci_scan_root_bridge() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 14/30] PCI/x86: Refine pci_acpi_scan_root() with generic pci_host_bridge Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 15/30] PCI/IA64: " Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 16/30] PCI/IA64: Fix the build warning about pci_domain_nr() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 17/30] PCI/powerpc: Rename pcibios_root_bridge_prepare() Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 18/30] PCI/powerpc: Use pci_scan_root_bridge() for simplicity Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 19/30] PCI: Remove weak pcibios_root_bridge_prepare() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 20/30] PCI/sparc: Use pci_scan_root_bridge() for simplicity Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 21/30] PCI: Introduce pci_bus_child_max_busnr() Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 22/30] PCI/Parisc: Use pci_scan_root_bus() for simplicity Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 23/30] PCI/mvebu: Use pci_common_init_dev() to simplify code Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-22 17:40   ` Thomas Petazzoni
2015-01-22 17:40     ` Thomas Petazzoni
2015-01-22 17:40     ` Thomas Petazzoni
2015-01-22 17:40     ` Thomas Petazzoni
2015-01-22 17:40     ` Thomas Petazzoni
2015-01-23  2:11     ` Yijing Wang
2015-01-23  2:11     ` Yijing Wang
2015-01-23  2:11       ` Yijing Wang
2015-01-23  2:11       ` Yijing Wang
2015-01-23  2:11       ` Yijing Wang
2015-01-23  2:11       ` Yijing Wang
2015-02-16 17:46     ` Lorenzo Pieralisi
2015-02-16 17:46       ` Lorenzo Pieralisi
2015-02-16 17:46       ` Lorenzo Pieralisi
2015-01-22 17:40   ` Thomas Petazzoni [this message]
     [not found] ` <1421800225-26230-1-git-send-email-wangyijing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-01-21  0:30   ` [PATCH v2 24/30] PCI/tegra: Remove redundant tegra_pcie_scan_bus() Yijing Wang
2015-01-21  0:30     ` Yijing Wang
2015-01-21  0:30     ` Yijing Wang
2015-01-21  0:30     ` Yijing Wang
2015-01-21  0:30     ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 25/30] PCI/designware: Use pci_scan_root_bus() for simplicity Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 26/30] PCI/xgene: Use pci_scan_root_bus() instead of pci_create_root_bus() Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 27/30] PCI: Rename __pci_create_root_bus() to pci_create_root_bus() Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 28/30] PCI: Export find_pci_host_bridge() Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 29/30] PCI: Remove platform specific pci_domain_nr() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-21  0:30 ` [PATCH v2 30/30] PCI: Remove pci_bus_assign_domain_nr() Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30   ` Yijing Wang
2015-01-21  0:30 ` Yijing Wang
2015-01-30  9:10 ` [PATCH v2 00/30] Refine PCI scan interfaces and make generic pci host bridge Yijing Wang
2015-01-30  9:10 ` Yijing Wang
2015-01-30  9:10   ` Yijing Wang
2015-01-30  9:10   ` Yijing Wang
2015-01-30  9:10   ` Yijing Wang
2015-01-30  9:10   ` Yijing Wang
2015-01-30 15:45   ` Bjorn Helgaas
2015-01-30 15:45   ` Bjorn Helgaas
2015-01-30 15:45     ` Bjorn Helgaas
2015-01-30 15:45     ` Bjorn Helgaas
2015-01-30 15:45     ` Bjorn Helgaas
2015-01-31  0:55     ` Yijing Wang
2015-01-31  0:55       ` Yijing Wang
2015-01-31  0:55       ` Yijing Wang
2015-01-31  0:55       ` Yijing Wang
2015-01-31  0:55       ` Yijing Wang
2015-02-14 19:45 ` Lorenzo Pieralisi
2015-02-14 19:45   ` Lorenzo Pieralisi
2015-02-14 19:45   ` Lorenzo Pieralisi
2015-02-14 19:45   ` Lorenzo Pieralisi
2015-02-15  1:11   ` Yijing Wang
2015-02-15  1:11     ` Yijing Wang
2015-02-15  1:11     ` Yijing Wang
2015-02-15  1:11     ` Yijing Wang
2015-02-15  1:11     ` Yijing Wang
2015-02-16  1:18   ` Yijing Wang
2015-02-16  1:18     ` Yijing Wang
2015-02-16  1:18     ` Yijing Wang
2015-02-16  1:18     ` Yijing Wang
2015-02-16  1:18     ` Yijing Wang
2015-02-16  3:13     ` Benjamin Herrenschmidt
2015-02-16  3:13       ` Benjamin Herrenschmidt
2015-02-16  3:13       ` Benjamin Herrenschmidt
2015-02-16  3:13       ` Benjamin Herrenschmidt
2015-02-16  3:13       ` Benjamin Herrenschmidt
2015-02-16  3:28       ` Yijing Wang
2015-02-16  3:28         ` Yijing Wang
2015-02-16  3:28         ` Yijing Wang
2015-02-16  3:28         ` Yijing Wang
2015-02-16  3:28         ` Yijing Wang
2015-02-25 23:09 ` Bjorn Helgaas
2015-02-25 23:09 ` Bjorn Helgaas
2015-02-25 23:09   ` Bjorn Helgaas
2015-02-25 23:09   ` Bjorn Helgaas
2015-02-25 23:09   ` Bjorn Helgaas
2015-02-26  0:54   ` Yijing Wang
2015-02-26  0:54     ` Yijing Wang
2015-02-26  0:54     ` Yijing Wang
2015-02-26  0:54     ` Yijing Wang
2015-02-26  0:54     ` Yijing Wang
2015-02-26  0:54   ` Yijing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20150122184000.63ba06bb__12904.9051939093$1421948438$gmane$org@free-electrons.com' \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=jason@lakedaemon.net \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liviu@dudau.co.uk \
    --cc=marc.zyngier@arm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=wangyijing@huawei.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.