Re: [PATCH v1 1/3] i2c: designware-pci: shrink dw_pci_controllers array

[David Cohen <david.a.cohen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

Hi Andy,

On Thu, Jan 22, 2015 at 04:44:27PM +0200, Andy Shevchenko wrote:
> There is no need to duplicate same data for each controller. If we need
> specific stuff for a certain controller in the future we may add it later. The
> patch leaves one controller per platform.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c | 96 ++++++------------------------
>  1 file changed, 19 insertions(+), 77 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index acb40f9..9237abb 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -40,17 +40,8 @@
>  #define DRIVER_NAME "i2c-designware-pci"
>  
>  enum dw_pci_ctl_id_t {
> -	moorestown_0,
> -	moorestown_1,
> -	moorestown_2,
> -
> -	medfield_0,
> -	medfield_1,
> -	medfield_2,
> -	medfield_3,
> -	medfield_4,
> -	medfield_5,
> -
> +	moorestown,

Since you're doing this rework, could you remove moorestown for good?
It's no longer supported as one of intel mid's platform anyway.

Br, David