From: Phil Oester <kernel@linuxace.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, lennart@poettering.net
Subject: Re: [PATCH iptables] iptables: use flock() instead of abstract unix sockets
Date: Sat, 24 Jan 2015 14:35:04 -0800 [thread overview]
Message-ID: <20150124223503.GA22316@home> (raw)
In-Reply-To: <1421690957-11279-1-git-send-email-pablo@netfilter.org>
On Mon, Jan 19, 2015 at 07:09:17PM +0100, Pablo Neira Ayuso wrote:
> Abstract unix sockets cannot be used to synchronize several concurrent
> instances of iptables since an unpriviledged process can create them and
> prevent the legitimate iptables instance from running.
>
> Use flock() and /run instead as suggested by Lennart Poettering.
>
> Fixes: 93587a0 ("ip[6]tables: Add locking to prevent concurrent instances")
> Reported-by: Lennart Poettering <lennart@poettering.net>
Looks good Pablo. Thanks for finding this Lennart.
Phil
prev parent reply other threads:[~2015-01-24 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 18:09 [PATCH iptables] iptables: use flock() instead of abstract unix sockets Pablo Neira Ayuso
2015-01-19 18:36 ` Lennart Poettering
2015-01-24 22:35 ` Phil Oester [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150124223503.GA22316@home \
--to=kernel@linuxace.com \
--cc=lennart@poettering.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.