On Saturday 24 January 2015 23:08:00 Arnd Bergmann wrote: > On Saturday 24 January 2015 13:00:00 Pali Rohár wrote: > > Another regression for DT setup (which does not occur for > > board code): > > > > omap_hsmmc driver does not export slot_name sysfs entry > > because it not supported by DT yet. Entry slot_name is used > > by userspace application to determinate if mmc block device > > is internal eMMC memory or external uSD card. So support > > for this property also in DT is needed. > > > Here is simple patch which fix this problem: > The sysfs file only exists for the two OMAP drivers, and the > naming is used only by board-n8x0, board-rx51 and > board-omap3logic. > > It may be better to add a board-specific hack for these to > keep the existing user space working but not spread the use > of this file anywhere else. > > Arnd Why? omap_hsmmc.c has already support for slot_name sysfs entry, just it is not filled from DT data (only from platform_data)... -- Pali Rohár pali.rohar@gmail.com