From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757703AbbA0DXP (ORCPT ); Mon, 26 Jan 2015 22:23:15 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:46892 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757517AbbA0DXO (ORCPT ); Mon, 26 Jan 2015 22:23:14 -0500 Date: Tue, 27 Jan 2015 12:23:07 +0900 From: Minchan Kim To: Ganesh Mahendran Cc: Andrew Morton , Nitin Gupta , Linux-MM , linux-kernel Subject: Re: [PATCH] mm/zsmalloc: add log for module load/unload Message-ID: <20150127032307.GB16797@blaptop> References: <1422107321-9973-1-git-send-email-opensource.ganesh@gmail.com> <20150126151942.2dd88d5221423e7379b43a06@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Ganesh, On Tue, Jan 27, 2015 at 10:07:53AM +0800, Ganesh Mahendran wrote: > Hello, Andrew > > 2015-01-27 7:19 GMT+08:00 Andrew Morton : > > On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran wrote: > > > >> Sometimes, we want to know whether a module is loaded or unloaded > >> from the log. > > > > Why? What's special about zsmalloc? > > > > Please provide much better justification than this. > > When I debug with the zsmalloc module built in kernel. > After system boots up, I did not see: > /sys/kernel/debug/zsmalloc dir. > > Although the reason for this is that I made a mistake. I > forgot to add debugfs entry in /etc/fstab. > But I think it is suitable to add information for a module load/unload. > Then we can get this by: > dmesg | grep zsmalloc. I understand your trouble but it's general problem, not zsmalloc specific. Then, if you really want to fix, you should approach more generic ways. Thanks. -- Kind regards, Minchan Kim From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by kanga.kvack.org (Postfix) with ESMTP id 812F06B0032 for ; Mon, 26 Jan 2015 22:23:14 -0500 (EST) Received: by mail-pa0-f47.google.com with SMTP id lj1so15598729pab.6 for ; Mon, 26 Jan 2015 19:23:14 -0800 (PST) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com. [2607:f8b0:400e:c02::233]) by mx.google.com with ESMTPS id rk11si14595871pab.99.2015.01.26.19.23.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 Jan 2015 19:23:13 -0800 (PST) Received: by mail-pd0-f179.google.com with SMTP id v10so16073229pde.10 for ; Mon, 26 Jan 2015 19:23:13 -0800 (PST) Date: Tue, 27 Jan 2015 12:23:07 +0900 From: Minchan Kim Subject: Re: [PATCH] mm/zsmalloc: add log for module load/unload Message-ID: <20150127032307.GB16797@blaptop> References: <1422107321-9973-1-git-send-email-opensource.ganesh@gmail.com> <20150126151942.2dd88d5221423e7379b43a06@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Ganesh Mahendran Cc: Andrew Morton , Nitin Gupta , Linux-MM , linux-kernel Hello Ganesh, On Tue, Jan 27, 2015 at 10:07:53AM +0800, Ganesh Mahendran wrote: > Hello, Andrew > > 2015-01-27 7:19 GMT+08:00 Andrew Morton : > > On Sat, 24 Jan 2015 21:48:41 +0800 Ganesh Mahendran wrote: > > > >> Sometimes, we want to know whether a module is loaded or unloaded > >> from the log. > > > > Why? What's special about zsmalloc? > > > > Please provide much better justification than this. > > When I debug with the zsmalloc module built in kernel. > After system boots up, I did not see: > /sys/kernel/debug/zsmalloc dir. > > Although the reason for this is that I made a mistake. I > forgot to add debugfs entry in /etc/fstab. > But I think it is suitable to add information for a module load/unload. > Then we can get this by: > dmesg | grep zsmalloc. I understand your trouble but it's general problem, not zsmalloc specific. Then, if you really want to fix, you should approach more generic ways. Thanks. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org