From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757223AbbA0HCZ (ORCPT ); Tue, 27 Jan 2015 02:02:25 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:58498 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbbA0HCW (ORCPT ); Tue, 27 Jan 2015 02:02:22 -0500 Date: Tue, 27 Jan 2015 16:02:09 +0900 From: Gyungoh Yoo To: sameo@linux.intel.com, lee.jones@linaro.org, grant.likely@linaro.org, robh+dt@kernel.org, jg1.han@samsung.com, cooloney@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, trivial@kernel.org Cc: akpm@linux-foundation.org, jic23@kernel.org, thomas.petazzoni@free-electrons.com, ktsai@capellamicro.com, hs@denx.de, stwiss.opensource@diasemi.com, matti.vaittinen@nsn.com, broonie@kernel.org, jason@lakedaemon.net, heiko@sntech.de, shawn.guo@freescale.com, florian.vaussard@epfl.ch, andrew@lunn.ch, antonynpavlov@gmail.com, hytszk@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v10 4/6] devicetree: Add new SKY81452 backlight binding Message-ID: <20150127070209.GA3301@jack-ThinkPad-T520> References: <1421994515-3070-1-git-send-email-jack.yoo@skyworksinc.com> <1421994515-3070-5-git-send-email-jack.yoo@skyworksinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1421994515-3070-5-git-send-email-jack.yoo@skyworksinc.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 23, 2015 at 03:28:33PM +0900, gyungoh@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > Acked-by: Bryan Wu The existing Ack is only for backlight driver. DT Ack please. > --- > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable property to generic property for GPIO > Made up the example for backlight DT > > Changes v7: > Nothing > > Changes v6: > Nothing > > Changes v5: > Nothing > > Changes v4: > Nothing > > Changes v3: > Nothing > > Changes v2: > Added reg attribute for I2C slave address > > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > new file mode 100644 > index 0000000..8daebf5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > @@ -0,0 +1,29 @@ > +SKY81452-backlight bindings > + > +Required properties: > +- compatible : Must be "skyworks,sky81452-backlight" > + > +Optional properties: > +- name : Name of backlight device. Default is 'lcd-backlight'. > +- gpios : GPIO to use to EN pin. > + See Documentation/devicetree/bindings/gpio/gpio.txt > +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. > +- skyworks,ignore-pwm : Ignore both PWM input > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. > +- skyworks,phase-shift : Enable phase shift mode > +- skyworks,ovp-level : Over-voltage protection level. > + Should be between 14 or 28V. > +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. > +- skyworks,current-limit : It should be 2300mA or 2750mA. > + > +Example: > + > + backlight { > + compatible = "skyworks,sky81452-backlight"; > + name = "pwm-backlight"; > + skyworks,en-channels = <0x3f>; > + skyworks,ignore-pwm; > + skyworks,phase-shift; > + skyworks,ovp-level = <20>; > + skyworks,current-limit = <2300>; > + }; > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gyungoh Yoo Date: Tue, 27 Jan 2015 07:02:09 +0000 Subject: Re: [PATCH v10 4/6] devicetree: Add new SKY81452 backlight binding Message-Id: <20150127070209.GA3301@jack-ThinkPad-T520> List-Id: References: <1421994515-3070-1-git-send-email-jack.yoo@skyworksinc.com> <1421994515-3070-5-git-send-email-jack.yoo@skyworksinc.com> In-Reply-To: <1421994515-3070-5-git-send-email-jack.yoo@skyworksinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sameo@linux.intel.com, lee.jones@linaro.org, grant.likely@linaro.org, robh+dt@kernel.org, jg1.han@samsung.com, cooloney@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, trivial@kernel.org Cc: akpm@linux-foundation.org, jic23@kernel.org, thomas.petazzoni@free-electrons.com, ktsai@capellamicro.com, hs@denx.de, stwiss.opensource@diasemi.com, matti.vaittinen@nsn.com, broonie@kernel.org, jason@lakedaemon.net, heiko@sntech.de, shawn.guo@freescale.com, florian.vaussard@epfl.ch, andrew@lunn.ch, antonynpavlov@gmail.com, hytszk@gmail.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org On Fri, Jan 23, 2015 at 03:28:33PM +0900, gyungoh@gmail.com wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo > Acked-by: Bryan Wu The existing Ack is only for backlight driver. DT Ack please. > --- > Changes v10: > Nothing > > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable property to generic property for GPIO > Made up the example for backlight DT > > Changes v7: > Nothing > > Changes v6: > Nothing > > Changes v5: > Nothing > > Changes v4: > Nothing > > Changes v3: > Nothing > > Changes v2: > Added reg attribute for I2C slave address > > .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > > diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > new file mode 100644 > index 0000000..8daebf5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt > @@ -0,0 +1,29 @@ > +SKY81452-backlight bindings > + > +Required properties: > +- compatible : Must be "skyworks,sky81452-backlight" > + > +Optional properties: > +- name : Name of backlight device. Default is 'lcd-backlight'. > +- gpios : GPIO to use to EN pin. > + See Documentation/devicetree/bindings/gpio/gpio.txt > +- skyworks,en-channels : Enable mask for current sink channel 1 to 6. > +- skyworks,ignore-pwm : Ignore both PWM input > +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming. > +- skyworks,phase-shift : Enable phase shift mode > +- skyworks,ovp-level : Over-voltage protection level. > + Should be between 14 or 28V. > +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V. > +- skyworks,current-limit : It should be 2300mA or 2750mA. > + > +Example: > + > + backlight { > + compatible = "skyworks,sky81452-backlight"; > + name = "pwm-backlight"; > + skyworks,en-channels = <0x3f>; > + skyworks,ignore-pwm; > + skyworks,phase-shift; > + skyworks,ovp-level = <20>; > + skyworks,current-limit = <2300>; > + }; > -- > 1.9.1 >