* [PATCH] ASoC: wm8731: init mutex in i2c init path
@ 2015-01-19 7:23 Manuel Lauss
2015-01-27 18:21 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Manuel Lauss @ 2015-01-19 7:23 UTC (permalink / raw)
To: alsa-devel; +Cc: Manuel Lauss
The I2C init path forgot to init the mutex, leading to an oops when
controls are accessed.
Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
Fixes an oops on bootup when alsactl tries to restore codec parameters
on my MIPS DB1300 board.
sound/soc/codecs/wm8731.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index b9211b4..b115ed8 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -717,6 +717,8 @@ static int wm8731_i2c_probe(struct i2c_client *i2c,
if (wm8731 == NULL)
return -ENOMEM;
+ mutex_init(&wm8731->lock);
+
wm8731->regmap = devm_regmap_init_i2c(i2c, &wm8731_regmap);
if (IS_ERR(wm8731->regmap)) {
ret = PTR_ERR(wm8731->regmap);
--
2.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wm8731: init mutex in i2c init path
2015-01-19 7:23 [PATCH] ASoC: wm8731: init mutex in i2c init path Manuel Lauss
@ 2015-01-27 18:21 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-01-27 18:21 UTC (permalink / raw)
To: alsa-devel; +Cc: alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]
On Mon, Jan 19, 2015 at 08:23:43AM +0100, Manuel Lauss wrote:
> The I2C init path forgot to init the mutex, leading to an oops when
> controls are accessed.
Applied, thanks. Please remember to CC maintainers on patches,
including driver maintainers as well as subsystem maintainers.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-27 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-19 7:23 [PATCH] ASoC: wm8731: init mutex in i2c init path Manuel Lauss
2015-01-27 18:21 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.