All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: James Ban <james.ban.opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Support Opensource <support.opensource@diasemi.com>,
	LKML <linux-kernel@vger.kernel.org>,
	David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [PATCH V2] regulator: da9211: Add gpio control for enable/disable of buck
Date: Tue, 27 Jan 2015 18:31:02 +0000	[thread overview]
Message-ID: <20150127183102.GF21293@sirena.org.uk> (raw)
In-Reply-To: <201501190238.t0J2cH7R013166@krsrvapps-01.diasemi.com>

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

On Mon, Jan 19, 2015 at 11:27:05AM +0900, James Ban wrote:

>  Optional properties:
> +- buck-enable-platform-gpios: platform gpio for control of BUCKA/BUCKB.
>  - Any optional property defined in regulator.txt

How about just "enable-gpios" - the name is pretty long and it's in the
node for the buck already.  Otherwise this looks fine.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2015-01-27 18:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19  2:27 [PATCH V2] regulator: da9211: Add gpio control for enable/disable of buck James Ban
2015-01-27 18:31 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127183102.GF21293@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=david.chen@diasemi.com \
    --cc=james.ban.opensource@diasemi.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=support.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.