* [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains
@ 2015-01-25 22:41 Yann E. MORIN
2015-01-27 21:13 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2015-01-25 22:41 UTC (permalink / raw)
To: buildroot
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
toolchain/helpers.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index 3121da4..61a3639 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk
@@ -347,6 +347,11 @@ check_unusable_toolchain = \
echo "them unsuitable as external toolchains for build systems" ; \
echo "such as Buildroot." ; \
exit 1 ; \
+ fi; \
+ with_sysroot=`$${__CROSS_CC} -v 2>&1 |sed -r -e '/.* --with-sysroot=([^[:space:]]+)[[:space:]].*/!d; s//\1/'`; \
+ if test "$${with_sysroot}" = "/" ; then \
+ echo "Distribution toolchains are unsuitable for use by Buildroot," ; \
+ echo "as they were configured in a way that makes them non-relocatable."; \
fi
#
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains
2015-01-25 22:41 [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains Yann E. MORIN
@ 2015-01-27 21:13 ` Arnout Vandecappelle
2015-01-27 21:16 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2015-01-27 21:13 UTC (permalink / raw)
To: buildroot
On 25/01/15 23:41, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> toolchain/helpers.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index 3121da4..61a3639 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -347,6 +347,11 @@ check_unusable_toolchain = \
> echo "them unsuitable as external toolchains for build systems" ; \
> echo "such as Buildroot." ; \
> exit 1 ; \
> + fi; \
> + with_sysroot=`$${__CROSS_CC} -v 2>&1 |sed -r -e '/.* --with-sysroot=([^[:space:]]+)[[:space:]].*/!d; s//\1/'`; \
> + if test "$${with_sysroot}" = "/" ; then \
> + echo "Distribution toolchains are unsuitable for use by Buildroot," ; \
> + echo "as they were configured in a way that makes them non-relocatable."; \
This sounds as if the problem is that the binary can't be moved to a different
place. But for pre-installed external toolchains, we don't do that.
But I guess the real problem is that we can't copy the libs to the staging dir,
right? So perhaps that should be written in this remark.
Regards,
Arnout
> fi
>
> #
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains
2015-01-27 21:13 ` Arnout Vandecappelle
@ 2015-01-27 21:16 ` Thomas Petazzoni
2015-01-28 18:34 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-01-27 21:16 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle,
On Tue, 27 Jan 2015 22:13:08 +0100, Arnout Vandecappelle wrote:
> This sounds as if the problem is that the binary can't be moved to a different
> place. But for pre-installed external toolchains, we don't do that.
>
> But I guess the real problem is that we can't copy the libs to the staging dir,
> right? So perhaps that should be written in this remark.
Yes the problem is more that such toolchains typically don't have a
clean sysroot, with just the C library, C library headers and kernel
headers.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains
2015-01-27 21:16 ` Thomas Petazzoni
@ 2015-01-28 18:34 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-01-28 18:34 UTC (permalink / raw)
To: buildroot
Arnout, Thomas, All,
On 2015-01-27 22:16 +0100, Thomas Petazzoni spake thusly:
> On Tue, 27 Jan 2015 22:13:08 +0100, Arnout Vandecappelle wrote:
>
> > This sounds as if the problem is that the binary can't be moved to a different
> > place. But for pre-installed external toolchains, we don't do that.
> >
> > But I guess the real problem is that we can't copy the libs to the staging dir,
> > right? So perhaps that should be written in this remark.
>
> Yes the problem is more that such toolchains typically don't have a
> clean sysroot, with just the C library, C library headers and kernel
> headers.
Well, both.
They are tainted with a lot of cruft we are not interested in, indeed.
But since the sysroot is not a sub-directory of the --prefix, they are
not relocatable either.
I'll update the error message to take your comments into account.
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-28 18:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-25 22:41 [Buildroot] [PATCH] toolchain/external: do not accept distro-class toolchains Yann E. MORIN
2015-01-27 21:13 ` Arnout Vandecappelle
2015-01-27 21:16 ` Thomas Petazzoni
2015-01-28 18:34 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.