All of lore.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Tony Lindgren <tony@atomide.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: GTA04 owners <gta04-owner@goldelico.com>,
	linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andreas Fenkart <afenkart@gmail.com>
Subject: [PATCH-RFC 0/3] mmc: switch to 1-bit mode which stopping clocks.
Date: Wed, 28 Jan 2015 10:35:24 +1100	[thread overview]
Message-ID: <20150127233118.32160.11899.stgit@notabene.brown> (raw)

An mmc/sdio host which is expecting interrupts from an SDIO card
should not turn off clocks unless the bus is configured to a width
of 1-bit.  In 4-bit mode interrupts may not be generated without
the clock.

This series fixes omap_hsmmc to set 1-bit mode when appropriate
and so allows my wifi chip to work much better.

This is an RFC.  The code seems to work, but I feel it could be
structured better (so that other drivers can share more of it), and
I need to convince myself there is no room for races.

Thanks,
NeilBrown


---

NeilBrown (3):
      mmc: core: allow non-blocking form of mmc_claim_host
      mmc: core: export functions for setting bus width.
      mmc: omap_hsmmc: switch to 1-bit before turning off clocks if interrupts expected.


 drivers/mmc/core/core.c       |    4 ++-
 drivers/mmc/core/sdio.c       |    8 +++---
 drivers/mmc/host/omap_hsmmc.c |   55 ++++++++++++++++++++++++++++++++++++++++-
 include/linux/mmc/host.h      |    4 +++
 4 files changed, 64 insertions(+), 7 deletions(-)

--
Signature


             reply	other threads:[~2015-01-27 23:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 23:35 NeilBrown [this message]
2015-01-27 23:35 ` [PATCH 2/3] mmc: core: export functions for setting bus width NeilBrown
2015-01-27 23:35 ` [PATCH 3/3] mmc: omap_hsmmc: switch to 1-bit before turning off clocks if interrupts expected NeilBrown
2015-01-28 20:18   ` Ulf Hansson
2015-01-28 21:08     ` NeilBrown
2015-01-27 23:35 ` [PATCH 1/3] mmc: core: allow non-blocking form of mmc_claim_host NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127233118.32160.11899.stgit@notabene.brown \
    --to=neilb@suse.de \
    --cc=afenkart@gmail.com \
    --cc=gta04-owner@goldelico.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.