All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org, rami.rosen@intel.com
Subject: Re: [PATCH v2] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
Date: Wed, 28 Jan 2015 22:22:28 -0800 (PST)	[thread overview]
Message-ID: <20150128.222228.633694287669808879.davem@davemloft.net> (raw)
In-Reply-To: <1422490991-4033-1-git-send-email-roopa@cumulusnetworks.com>

From: roopa@cumulusnetworks.com
Date: Wed, 28 Jan 2015 16:23:11 -0800

> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
> 
> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
> handler does not return any bytes in the skb.
> 
> Alternately, the skb->len check can be moved inside rtnl_notify.
> 
> For the bridge vlan case described in 92081, there is also a fix needed
> in bridge driver to generate a proper notification. Will fix that in
> subsequent patch.
> 
> v2: rebase patch on net tree
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>

Applied, thanks.

      reply	other threads:[~2015-01-29  6:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29  0:23 [PATCH v2] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify roopa
2015-01-29  6:22 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128.222228.633694287669808879.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rami.rosen@intel.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.