From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property Date: Wed, 28 Jan 2015 09:04:17 +0200 Message-ID: <20150128070417.GK17565@valkosipuli.retiisi.org.uk> References: <54B4DA81.7060900@samsung.com> <54B8D4D0.3000904@samsung.com> <54B933D0.1090004@samsung.com> <54BE7DAB.80702@samsung.com> <20150120174010.GA2900@amd> <54BF73B9.8060402@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <54BF73B9.8060402@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Pavel Machek , Rob Herring , linux-leds@vger.kernel.org, "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Bartlomiej Zolnierkiewicz , Bryan Wu , Richard Purdie , Sylwester Nawrocki , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Mark Brown List-Id: linux-leds@vger.kernel.org On Wed, Jan 21, 2015 at 10:39:05AM +0100, Jacek Anaszewski wrote: > I agree. I think that led-sources-cnt is redundant. A list property > can be read using of_prop_next_u32 function. I missed that and thus > proposed putting led-sources-cnt in each sub-node to be able to read > led-sources list with of_property_read_u32_array. > > Effectively, I propose to avoid adding led-sources-cnt property. You can also read the array size using of_get_property(). -- Regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk