From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761363AbbA1VzI (ORCPT ); Wed, 28 Jan 2015 16:55:08 -0500 Received: from mx-guillaumet.finsecur.com ([91.217.234.131]:59339 "EHLO guillaumet.finsecur.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932690AbbA1U3G (ORCPT ); Wed, 28 Jan 2015 15:29:06 -0500 Date: Wed, 28 Jan 2015 10:06:02 +0100 From: Sylvain Rochet To: Wenyou Yang Cc: nicolas.ferre@atmel.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, peda@axentia.se, sergei.shtylyov@cogentembedded.com, linux@maxim.org.za Message-ID: <20150128090602.GA19088@gradator.net> References: <1422409172-24178-1-git-send-email-wenyou.yang@atmel.com> <20150128085913.GA7742@gradator.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150128085913.GA7742@gradator.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 172.16.8.13 X-SA-Exim-Mail-From: sylvain.rochet@finsecur.com Subject: Re: [PATCH v4 00/13] AT91 pm cleanup for 3.20 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on guillaumet.finsecur.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Wenyou, On Wed, Jan 28, 2015 at 09:59:13AM +0100, Sylvain Rochet wrote: > Hello Wenyou, > > On Wed, Jan 28, 2015 at 09:39:32AM +0800, Wenyou Yang wrote: > > Hi Nicolas, > > > > This version is rebased on the branch: at91-3.20-cleanup of the repository > > git://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git > > > > It is purpose to clean up the PM code, includes the patches from Peter Rosin and Sylvain Rochet. > > > > Since verifying the USB clock and USB PLL disabling before suspending to memory, > > it aslo depends on the following patch serials from Sylvain: > > [PATCHv6 0/5] USB: gadget: atmel_usba_udc: Driver improvements > > [PATCHv7 0/6] USB: host: Atmel OHCI and EHCI drivers improvements > > > > Removes CONFIG_AT91_SLOW_CLOCK config item to simply the PM config, > > The suspend to standby mode uses the same sram function as the suspend to memory mode. > > Remove some unused code. > > > > Alexandr & Sylvain, Thank you very much for so many feedbacks. > > > > Changes in v2: > > - Rebase on the at91-3.20-cleanup branch > > - Recover the verify clock condition, only for suspend to memory. > > - Collect ACK from Alexandre > > - Add the macro for PM mode > > > > Changes in v3: > > - Clear unused state argument in at91_pm_verify_clocks() > > - Remove pr_info("AT91:... slow_clock ? ..") in patch 07/13. > > Changes in v4: ? :-) Actually, I guess it is: Changes in v2: - Rebase on the at91-3.20-cleanup branch - Recover the verify clock condition, only for suspend to memory. - Collect ACK from Alexandre - Add the macro for PM mode Changes in v3 - Sylvain splits the patch in two - Add handling if no sram allocated for PM - Retain the STANDBY and SUSPEND_MEM select in at91_pm_enter. Changes in v4: - Clear unused state argument in at91_pm_verify_clocks() - Remove pr_info("AT91:... slow_clock ? ..") in patch 07/13. (I prefer the reverse order, but, details) Sylvain From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvain.rochet@finsecur.com (Sylvain Rochet) Date: Wed, 28 Jan 2015 10:06:02 +0100 Subject: [PATCH v4 00/13] AT91 pm cleanup for 3.20 In-Reply-To: <20150128085913.GA7742@gradator.net> References: <1422409172-24178-1-git-send-email-wenyou.yang@atmel.com> <20150128085913.GA7742@gradator.net> Message-ID: <20150128090602.GA19088@gradator.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Wenyou, On Wed, Jan 28, 2015 at 09:59:13AM +0100, Sylvain Rochet wrote: > Hello Wenyou, > > On Wed, Jan 28, 2015 at 09:39:32AM +0800, Wenyou Yang wrote: > > Hi Nicolas, > > > > This version is rebased on the branch: at91-3.20-cleanup of the repository > > git://git.kernel.org/pub/scm/linux/kernel/git/nferre/linux-at91.git > > > > It is purpose to clean up the PM code, includes the patches from Peter Rosin and Sylvain Rochet. > > > > Since verifying the USB clock and USB PLL disabling before suspending to memory, > > it aslo depends on the following patch serials from Sylvain: > > [PATCHv6 0/5] USB: gadget: atmel_usba_udc: Driver improvements > > [PATCHv7 0/6] USB: host: Atmel OHCI and EHCI drivers improvements > > > > Removes CONFIG_AT91_SLOW_CLOCK config item to simply the PM config, > > The suspend to standby mode uses the same sram function as the suspend to memory mode. > > Remove some unused code. > > > > Alexandr & Sylvain, Thank you very much for so many feedbacks. > > > > Changes in v2: > > - Rebase on the at91-3.20-cleanup branch > > - Recover the verify clock condition, only for suspend to memory. > > - Collect ACK from Alexandre > > - Add the macro for PM mode > > > > Changes in v3: > > - Clear unused state argument in at91_pm_verify_clocks() > > - Remove pr_info("AT91:... slow_clock ? ..") in patch 07/13. > > Changes in v4: ? :-) Actually, I guess it is: Changes in v2: - Rebase on the at91-3.20-cleanup branch - Recover the verify clock condition, only for suspend to memory. - Collect ACK from Alexandre - Add the macro for PM mode Changes in v3 - Sylvain splits the patch in two - Add handling if no sram allocated for PM - Retain the STANDBY and SUSPEND_MEM select in at91_pm_enter. Changes in v4: - Clear unused state argument in at91_pm_verify_clocks() - Remove pr_info("AT91:... slow_clock ? ..") in patch 07/13. (I prefer the reverse order, but, details) Sylvain