From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760125AbbA1UdE (ORCPT ); Wed, 28 Jan 2015 15:33:04 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:57504 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755793AbbA1Uc7 (ORCPT ); Wed, 28 Jan 2015 15:32:59 -0500 Date: Wed, 28 Jan 2015 11:54:01 +0200 From: Baruch Siach To: Lyra Zhang Cc: Chunyan Zhang , "gregkh@linuxfoundation.org" , Mark Rutland , "gnomes@lxorguk.ukuu.org.uk" , Heiko =?iso-8859-1?Q?St=FCbner?= , "andrew@lunn.ch" , "jslaby@suse.cz" , "lanqing.liu@spreadtrum.com" , Arnd Bergmann , "zhizhou.zhang" , "geng.ren@spreadtrum.com" , "antonynpavlov@gmail.com" , "linux-serial@vger.kernel.org" , Grant Likely , Orson Zhai , "florian.vaussard@epfl.ch" , "devicetree@vger.kernel.org" , "jason@lakedaemon.net" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , Hayato Suzuki , "robh+dt@kernel.org" , Wei Qiao =?utf-8?B?KOS5lOS8nyk=?= , "linux-arm-kernel@lists.infradead.org" , Peter Hurley , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kumar Gala , Shawn Guo Subject: Re: [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support Message-ID: <20150128095401.GC14175@tarshish> References: <1422413261-17184-1-git-send-email-chunyan.zhang@spreadtrum.com> <1422413261-17184-3-git-send-email-chunyan.zhang@spreadtrum.com> <20150128061250.GQ2555@sapphire.tkos.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lyra Zhang, On Wed, Jan 28, 2015 at 04:46:33PM +0800, Lyra Zhang wrote: > On Wed, Jan 28, 2015 at 2:12 PM, Baruch Siach wrote: > > On Wed, Jan 28, 2015 at 10:47:41AM +0800, Chunyan Zhang wrote: > >> + if (uart_handle_sysrq_char(port, ch)) > >> + continue; > > > > My comment[1] on a previous version of this patch still stands. > > uart_handle_sysrq_char is a NOP when SUPPORT_SYSRQ is not defined. > > yes, there are two definitions in serial_core.h, and it returns 0 when > SUPPORT_SYSRQ is not defined. > so, I think my code behavior does not hurt, right? Right. I just wanted to point out that you can easily define SUPPORT_SYSRQ as appropriate like many other serial drivers do to get sysrq support. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support Date: Wed, 28 Jan 2015 11:54:01 +0200 Message-ID: <20150128095401.GC14175@tarshish> References: <1422413261-17184-1-git-send-email-chunyan.zhang@spreadtrum.com> <1422413261-17184-3-git-send-email-chunyan.zhang@spreadtrum.com> <20150128061250.GQ2555@sapphire.tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Lyra Zhang Cc: Mark Rutland , "andrew@lunn.ch" , Heiko =?iso-8859-1?Q?St=FCbner?= , "gnomes@lxorguk.ukuu.org.uk" , "jslaby@suse.cz" , "lanqing.liu@spreadtrum.com" , Pawel Moll , Chunyan Zhang , "zhizhou.zhang" , "geng.ren@spreadtrum.com" , "antonynpavlov@gmail.com" , "linux-serial@vger.kernel.org" , Grant Likely , Orson Zhai , "florian.vaussard@epfl.ch" , "devicetree@vger.kernel.org" , "jason@lakedaemon.net" , Arnd Bergmann , "ijc+devicetree@hellion.org.uk" List-Id: devicetree@vger.kernel.org Hi Lyra Zhang, On Wed, Jan 28, 2015 at 04:46:33PM +0800, Lyra Zhang wrote: > On Wed, Jan 28, 2015 at 2:12 PM, Baruch Siach wrote: > > On Wed, Jan 28, 2015 at 10:47:41AM +0800, Chunyan Zhang wrote: > >> + if (uart_handle_sysrq_char(port, ch)) > >> + continue; > > > > My comment[1] on a previous version of this patch still stands. > > uart_handle_sysrq_char is a NOP when SUPPORT_SYSRQ is not defined. > > yes, there are two definitions in serial_core.h, and it returns 0 when > SUPPORT_SYSRQ is not defined. > so, I think my code behavior does not hurt, right? Right. I just wanted to point out that you can easily define SUPPORT_SYSRQ as appropriate like many other serial drivers do to get sysrq support. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - From mboxrd@z Thu Jan 1 00:00:00 1970 From: baruch@tkos.co.il (Baruch Siach) Date: Wed, 28 Jan 2015 11:54:01 +0200 Subject: [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support In-Reply-To: References: <1422413261-17184-1-git-send-email-chunyan.zhang@spreadtrum.com> <1422413261-17184-3-git-send-email-chunyan.zhang@spreadtrum.com> <20150128061250.GQ2555@sapphire.tkos.co.il> Message-ID: <20150128095401.GC14175@tarshish> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Lyra Zhang, On Wed, Jan 28, 2015 at 04:46:33PM +0800, Lyra Zhang wrote: > On Wed, Jan 28, 2015 at 2:12 PM, Baruch Siach wrote: > > On Wed, Jan 28, 2015 at 10:47:41AM +0800, Chunyan Zhang wrote: > >> + if (uart_handle_sysrq_char(port, ch)) > >> + continue; > > > > My comment[1] on a previous version of this patch still stands. > > uart_handle_sysrq_char is a NOP when SUPPORT_SYSRQ is not defined. > > yes, there are two definitions in serial_core.h, and it returns 0 when > SUPPORT_SYSRQ is not defined. > so, I think my code behavior does not hurt, right? Right. I just wanted to point out that you can easily define SUPPORT_SYSRQ as appropriate like many other serial drivers do to get sysrq support. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -