* make allyesconfig i386 build failure with next-20150122 @ 2015-01-22 19:10 Jim Davis 2015-01-26 21:59 ` make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) Guenter Roeck 0 siblings, 1 reply; 7+ messages in thread From: Jim Davis @ 2015-01-22 19:10 UTC (permalink / raw) To: Stephen Rothwell, linux-next, linux-kernel, Greg Kroah-Hartman, devel, isdn, netdev make ARCH=i386 allyesconfig fails with drivers/staging/built-in.o: In function `reset': (.text+0x2ae89d): multiple definition of `reset' drivers/isdn/built-in.o:(.text+0x185dc2): first defined here make[1]: *** [drivers/built-in.o] Error 1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) 2015-01-22 19:10 make allyesconfig i386 build failure with next-20150122 Jim Davis @ 2015-01-26 21:59 ` Guenter Roeck 2015-01-26 22:46 ` Greg Kroah-Hartman 2015-01-28 17:36 ` Greg Kroah-Hartman 0 siblings, 2 replies; 7+ messages in thread From: Guenter Roeck @ 2015-01-26 21:59 UTC (permalink / raw) To: Jim Davis Cc: Stephen Rothwell, linux-next, linux-kernel, Greg Kroah-Hartman, devel, isdn, netdev, Thomas Petazzoni On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: > make ARCH=i386 allyesconfig fails with > > drivers/staging/built-in.o: In function `reset': > (.text+0x2ae89d): multiple definition of `reset' > drivers/isdn/built-in.o:(.text+0x185dc2): first defined here > make[1]: *** [drivers/built-in.o] Error 1 Culprit: commit b2ebd4be6fa1d2329b63531b044f9e25474981cb Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Date: Wed Dec 31 10:11:10 2014 +0100 staging: fbtft: add fb_agm1264k-fl driver A global function named 'reset' isn't really a good idea. Not that the global function with the same name in the isdn code is better ;-). Guenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) 2015-01-26 21:59 ` make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) Guenter Roeck @ 2015-01-26 22:46 ` Greg Kroah-Hartman 2015-01-28 17:36 ` Greg Kroah-Hartman 1 sibling, 0 replies; 7+ messages in thread From: Greg Kroah-Hartman @ 2015-01-26 22:46 UTC (permalink / raw) To: Guenter Roeck Cc: Jim Davis, Stephen Rothwell, linux-next, linux-kernel, devel, isdn, netdev, Thomas Petazzoni On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: > On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: > > make ARCH=i386 allyesconfig fails with > > > > drivers/staging/built-in.o: In function `reset': > > (.text+0x2ae89d): multiple definition of `reset' > > drivers/isdn/built-in.o:(.text+0x185dc2): first defined here > > make[1]: *** [drivers/built-in.o] Error 1 > > Culprit: > > commit b2ebd4be6fa1d2329b63531b044f9e25474981cb > Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Date: Wed Dec 31 10:11:10 2014 +0100 > > staging: fbtft: add fb_agm1264k-fl driver > > A global function named 'reset' isn't really a good idea. > > Not that the global function with the same name in the isdn code > is better ;-). Agreed, the fbtft code is now fixed. Patches to fix the isdn code would be gladly accepted as well :) thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) @ 2015-01-26 22:46 ` Greg Kroah-Hartman 0 siblings, 0 replies; 7+ messages in thread From: Greg Kroah-Hartman @ 2015-01-26 22:46 UTC (permalink / raw) To: Guenter Roeck Cc: devel, Stephen Rothwell, isdn, netdev, linux-kernel, linux-next, Jim Davis On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: > On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: > > make ARCH=i386 allyesconfig fails with > > > > drivers/staging/built-in.o: In function `reset': > > (.text+0x2ae89d): multiple definition of `reset' > > drivers/isdn/built-in.o:(.text+0x185dc2): first defined here > > make[1]: *** [drivers/built-in.o] Error 1 > > Culprit: > > commit b2ebd4be6fa1d2329b63531b044f9e25474981cb > Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Date: Wed Dec 31 10:11:10 2014 +0100 > > staging: fbtft: add fb_agm1264k-fl driver > > A global function named 'reset' isn't really a good idea. > > Not that the global function with the same name in the isdn code > is better ;-). Agreed, the fbtft code is now fixed. Patches to fix the isdn code would be gladly accepted as well :) thanks, greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) 2015-01-26 22:46 ` Greg Kroah-Hartman (?) @ 2015-01-27 2:42 ` Guenter Roeck 2015-01-27 13:04 ` Tilman Schmidt -1 siblings, 1 reply; 7+ messages in thread From: Guenter Roeck @ 2015-01-27 2:42 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Jim Davis, Stephen Rothwell, linux-next, linux-kernel, devel, isdn, netdev, Thomas Petazzoni On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote: > On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: >> On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: >>> make ARCH=i386 allyesconfig fails with >>> >>> drivers/staging/built-in.o: In function `reset': >>> (.text+0x2ae89d): multiple definition of `reset' >>> drivers/isdn/built-in.o:(.text+0x185dc2): first defined here >>> make[1]: *** [drivers/built-in.o] Error 1 >> >> Culprit: >> >> commit b2ebd4be6fa1d2329b63531b044f9e25474981cb >> Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> Date: Wed Dec 31 10:11:10 2014 +0100 >> >> staging: fbtft: add fb_agm1264k-fl driver >> >> A global function named 'reset' isn't really a good idea. >> >> Not that the global function with the same name in the isdn code >> is better ;-). > > Agreed, the fbtft code is now fixed. Patches to fix the isdn code would > be gladly accepted as well :) > Did you have a look into the isdn code ? It will need someone with a lot of spare time to clean this code up. Guenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) 2015-01-27 2:42 ` Guenter Roeck @ 2015-01-27 13:04 ` Tilman Schmidt 0 siblings, 0 replies; 7+ messages in thread From: Tilman Schmidt @ 2015-01-27 13:04 UTC (permalink / raw) To: Guenter Roeck, Greg Kroah-Hartman Cc: Jim Davis, Stephen Rothwell, linux-next, linux-kernel, devel, isdn, netdev, Thomas Petazzoni Am 27.01.2015 um 03:42 schrieb Guenter Roeck: > On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote: >> On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: >>> On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: >>>> make ARCH=i386 allyesconfig fails with >>>> >>>> drivers/staging/built-in.o: In function `reset': >>>> (.text+0x2ae89d): multiple definition of `reset' >>>> drivers/isdn/built-in.o:(.text+0x185dc2): first defined here >>>> make[1]: *** [drivers/built-in.o] Error 1 >>> >>> Culprit: >>> >>> commit b2ebd4be6fa1d2329b63531b044f9e25474981cb >>> Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >>> Date: Wed Dec 31 10:11:10 2014 +0100 >>> >>> staging: fbtft: add fb_agm1264k-fl driver >>> >>> A global function named 'reset' isn't really a good idea. >>> >>> Not that the global function with the same name in the isdn code >>> is better ;-). >> >> Agreed, the fbtft code is now fixed. Patches to fix the isdn code would >> be gladly accepted as well :) >> > > Did you have a look into the isdn code ? It will need someone > with a lot of spare time to clean this code up. Cleaning up the entire isdn code certainly will, but that particular problem is in fact much more limited. The function in question is declared, along with several other also much too generically named ones, in drivers/isdn/sc/card.h which is included nowhere outside drivers/isdn/sc. So these are really private functions of the SpellCaster driver which could easily be renamed. OTOH good old SpellCaster was an ISA card, and the sc driver depends on the deprecated I4L framework. I wonder if it's worth any effort. Tilman ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) 2015-01-26 21:59 ` make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) Guenter Roeck 2015-01-26 22:46 ` Greg Kroah-Hartman @ 2015-01-28 17:36 ` Greg Kroah-Hartman 1 sibling, 0 replies; 7+ messages in thread From: Greg Kroah-Hartman @ 2015-01-28 17:36 UTC (permalink / raw) To: Guenter Roeck Cc: devel, Stephen Rothwell, isdn, netdev, linux-kernel, linux-next, Jim Davis On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: > On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: > > make ARCH=i386 allyesconfig fails with > > > > drivers/staging/built-in.o: In function `reset': > > (.text+0x2ae89d): multiple definition of `reset' > > drivers/isdn/built-in.o:(.text+0x185dc2): first defined here > > make[1]: *** [drivers/built-in.o] Error 1 > > Culprit: > > commit b2ebd4be6fa1d2329b63531b044f9e25474981cb > Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Date: Wed Dec 31 10:11:10 2014 +0100 > > staging: fbtft: add fb_agm1264k-fl driver > > A global function named 'reset' isn't really a good idea. > > Not that the global function with the same name in the isdn code > is better ;-). It's been fixed in my tree for a while now :) ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-28 17:36 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-01-22 19:10 make allyesconfig i386 build failure with next-20150122 Jim Davis 2015-01-26 21:59 ` make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver) Guenter Roeck 2015-01-26 22:46 ` Greg Kroah-Hartman 2015-01-26 22:46 ` Greg Kroah-Hartman 2015-01-27 2:42 ` Guenter Roeck 2015-01-27 13:04 ` Tilman Schmidt 2015-01-28 17:36 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.