All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xander.huff@ni.com
Cc: gregkh@suse.de, jeff.westfahl@ni.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, jaeden.amero@ni.com,
	ben.shelton@ni.com, brad.mouring@ni.com, rich.tollerton@ni.com
Subject: Re: [PATCH 1/2] driver core: add device_poll interface
Date: Thu, 29 Jan 2015 14:32:29 -0800 (PST)	[thread overview]
Message-ID: <20150129.143229.481822772678018170.davem@davemloft.net> (raw)
In-Reply-To: <1422312393-61485-1-git-send-email-xander.huff@ni.com>

From: Xander Huff <xander.huff@ni.com>
Date: Mon, 26 Jan 2015 16:46:32 -0600

> From: Jeff Westfahl <jeff.westfahl@ni.com>
> 
> Add the device_poll interface to the driver core. This is a generic
> interface that any struct device can take advantage of to dynamically
> switch between using interrupts and polling. Many drivers can be easily
> modified to take advantage of this feature if desired.
> 
> This interface is most likely to be used along with the RT patch. It has
> only been used thus far on Ethernet interfaces. Even with the standard
> RT change to threaded interrupts for all devices, some RT applications
> can be sensitive to even the minimal hardware interrupt that still occurs
> with threaded interrupt handlers. The device_poll interface can be used
> to completely eliminate all hardware interrupts for a device and the
> associated jitter.
> 
> This is a standalone feature that should be submitted for review and
> possible inclusion in mainline, or maybe in the RT patch.
> 
> Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>

There is no reason any device driver needs to explicitly add support
for a feature like this.

Implement this at the IRQ handler level, and run the IRQ handler
itself from the poll thread.

No driver changes at all.

Sorry, I'm not applying this series, drivers already have to implement
too many things explicitly these days.

      parent reply	other threads:[~2015-01-29 22:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 22:46 [PATCH 1/2] driver core: add device_poll interface Xander Huff
2015-01-26 22:46 ` [PATCH 2/2] net: add device_poll functionality common to all net devices Xander Huff
2015-01-29 22:32 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129.143229.481822772678018170.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ben.shelton@ni.com \
    --cc=brad.mouring@ni.com \
    --cc=gregkh@suse.de \
    --cc=jaeden.amero@ni.com \
    --cc=jeff.westfahl@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rich.tollerton@ni.com \
    --cc=xander.huff@ni.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.