From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludovic.desroches@atmel.com (Ludovic Desroches)
Date: Thu, 29 Jan 2015 08:33:28 +0100
Subject: [PATCH] crypto: atmel: remove bogus select
In-Reply-To: <1780191.gdgDmCPaN0@wuerfel>
References: <1780191.gdgDmCPaN0@wuerfel>
Message-ID: <20150129073328.GC1097@odux.rfo.atmel.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Wed, Jan 28, 2015 at 09:09:16PM +0100, Arnd Bergmann wrote:
> The Atmel at91 crypto driver unconditionally selects AT_HDMAC,
> which results in a Kconfig warning if that driver is not enabled:
> 
> warning: (CRYPTO_DEV_ATMEL_AES) selects AT_HDMAC which has unmet direct dependencies (DMADEVICES && ARCH_AT91)
> 
> The crypty driver itself does not actually have a dependency
> on a particular dma engine, other than this being the one that
> is used in at91.
> 
> Removing the 'select' gets rid of the warning, with no apparent
> downsides.

This driver doesn't work without DMA. I think it is the reason why the
select AT_HDMAC was used.

> We should probably enable AT_HDMAC in sama5_defconfig, because
> it no longers gets enabled implicitly.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 2fb0fdfc87df..0c411c0aae99 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -348,7 +348,6 @@ config CRYPTO_DEV_ATMEL_AES
>  	select CRYPTO_AES
>  	select CRYPTO_ALGAPI
>  	select CRYPTO_BLKCIPHER
> -	select AT_HDMAC
>  	help
>  	  Some Atmel processors have AES hw accelerator.
>  	  Select this if you want to use the Atmel module for
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel