All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] Fix warning
@ 2015-01-09  2:16 Zeng Linggang
  2015-01-26 16:31 ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Zeng Linggang @ 2015-01-09  2:16 UTC (permalink / raw)
  To: ltp-list

* Fix "warning: comparison of unsigned expression < 0 is always false":
Some variable value number are defined as unsigned number. When they are
compared with zero, the zero would cast to an unsigned number. And it would be
always false. Fix these by defining them as signed number. And some cleanup.

Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
---
 testcases/kernel/io/disktest/dump.c                           |  2 +-
 testcases/kernel/syscalls/munmap/munmap01.c                   |  2 +-
 testcases/kernel/syscalls/munmap/munmap02.c                   |  2 +-
 .../kernel/syscalls/remap_file_pages/remap_file_pages01.c     | 11 +++++++----
 .../kernel/syscalls/remap_file_pages/remap_file_pages02.c     |  2 +-
 testcases/network/tcp_cmds/perf_lan/pingpong.c                |  6 +++---
 utils/sctp/lib/connectx.c                                     |  6 +++---
 7 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/testcases/kernel/io/disktest/dump.c b/testcases/kernel/io/disktest/dump.c
index eef119b..ffb5ce1 100644
--- a/testcases/kernel/io/disktest/dump.c
+++ b/testcases/kernel/io/disktest/dump.c
@@ -173,7 +173,7 @@ int dump_data(FILE * stream, const char *buff, const size_t buff_siz,
 
 int do_dump(child_args_t * args)
 {
-	size_t NumBytes = 0;
+	ssize_t NumBytes = 0;
 	OFF_T TargetLBA, TotalBytes = 0;
 	char *buff;
 	fd_t fd;
diff --git a/testcases/kernel/syscalls/munmap/munmap01.c b/testcases/kernel/syscalls/munmap/munmap01.c
index 67eb74b..0c16f34 100644
--- a/testcases/kernel/syscalls/munmap/munmap01.c
+++ b/testcases/kernel/syscalls/munmap/munmap01.c
@@ -152,7 +152,7 @@ int main(int ac, char **av)
  */
 void setup(void)
 {
-	size_t page_sz;		/* system page size */
+	int page_sz;
 
 	tst_sig(NOFORK, DEF_HANDLER, cleanup);
 
diff --git a/testcases/kernel/syscalls/munmap/munmap02.c b/testcases/kernel/syscalls/munmap/munmap02.c
index 2832e24..b7eca33 100644
--- a/testcases/kernel/syscalls/munmap/munmap02.c
+++ b/testcases/kernel/syscalls/munmap/munmap02.c
@@ -83,7 +83,7 @@
 char *TCID = "munmap02";
 int TST_TOTAL = 1;
 
-size_t page_sz;			/* system page size */
+static int page_sz;
 char *addr;			/* addr of memory mapped region */
 int fildes;			/* file descriptor for tempfile */
 unsigned int map_len;		/* length of the region to be mapped */
diff --git a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c
index 42ed804..6a45ebf 100644
--- a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c
+++ b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c
@@ -92,7 +92,7 @@
 /* Test case defines */
 #define WINDOW_START 0x48000000
 
-size_t page_sz;
+static int page_sz;
 size_t page_words;
 size_t cache_pages;
 size_t cache_sz;
@@ -183,7 +183,8 @@ again:
 		if (remap_file_pages(page, page_sz * 2, 0,
 				     (window_pages - i - 2), 0) == -1) {
 			tst_resm(TFAIL | TERRNO,
-				 "remap_file_pages error for page=%p, page_sz=%zu, window_pages=%zu",
+				 "remap_file_pages error for page=%p, "
+				 "page_sz=%d, window_pages=%zu",
 				 page, (page_sz * 2), (window_pages - i - 2));
 			cleanup(data);
 		}
@@ -196,7 +197,8 @@ again:
 		if (i & 1) {
 			if (data[i * page_sz] != window_pages - i) {
 				tst_resm(TFAIL,
-					 "hm, mapped incorrect data, data[%zu]=%d, (window_pages-%d)=%zu",
+					 "hm, mapped incorrect data, "
+					 "data[%d]=%d, (window_pages-%d)=%zu",
 					 (i * page_sz), data[i * page_sz], i,
 					 (window_pages - i));
 				cleanup(data);
@@ -204,7 +206,8 @@ again:
 		} else {
 			if (data[i * page_sz] != window_pages - i - 2) {
 				tst_resm(TFAIL,
-					 "hm, mapped incorrect data, data[%zu]=%d, (window_pages-%d-2)=%zu",
+					 "hm, mapped incorrect data, "
+					 "data[%d]=%d, (window_pages-%d-2)=%zu",
 					 (i * page_sz), data[i * page_sz], i,
 					 (window_pages - i - 2));
 				cleanup(data);
diff --git a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c
index d00d7ce..003ac77 100644
--- a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c
+++ b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c
@@ -83,7 +83,7 @@
 /* Test case defines */
 #define WINDOW_START 0x48000000
 
-size_t page_sz;
+static int page_sz;
 size_t page_words;
 size_t cache_pages;
 size_t cache_sz;
diff --git a/testcases/network/tcp_cmds/perf_lan/pingpong.c b/testcases/network/tcp_cmds/perf_lan/pingpong.c
index d02b552..746891e 100644
--- a/testcases/network/tcp_cmds/perf_lan/pingpong.c
+++ b/testcases/network/tcp_cmds/perf_lan/pingpong.c
@@ -207,7 +207,7 @@ int main(int argc, char *argv[])
 		while (1) {
 
 			len = sizeof(packet);
-			size_t cc;
+			ssize_t cc;
 			socklen_t fromlen;
 
 			/* Receive packet from socket */
@@ -239,7 +239,7 @@ int echopkt(int datalen, int npackets)
 	static uint8_t outpack[MAXPACKET];
 	register icmp_t *icp = (icmp_t *) outpack;
 	int i;
-	size_t cc;
+	ssize_t cc;
 
 	register u_char *datap = &outpack[8];
 
@@ -282,7 +282,7 @@ int echopkt(int datalen, int npackets)
 		if (i < 0 || i != cc) {
 			if (i < 0)
 				perror("sendto");
-			tst_resm(TINFO, "wrote %s %d chars, ret=%d",
+			tst_resm(TINFO, "wrote %s %zd chars, ret=%d",
 				 hostname, cc, i);
 			fflush(stdout);
 		}
diff --git a/utils/sctp/lib/connectx.c b/utils/sctp/lib/connectx.c
index b691f6b..cf8f5ed 100644
--- a/utils/sctp/lib/connectx.c
+++ b/utils/sctp/lib/connectx.c
@@ -66,7 +66,7 @@ static int __connectx_addrsize(const struct sockaddr *addrs,
 
 int __sctp_connectx(int fd, struct sockaddr *addrs, int addrcnt)
 {
-	socklen_t addrs_size = __connectx_addrsize(addrs, addrcnt);
+	int addrs_size = __connectx_addrsize(addrs, addrcnt);
 
 	if (addrs_size < 0)
 		return addrs_size;
@@ -117,7 +117,7 @@ static int __connectx(int fd, struct sockaddr *addrs, socklen_t addrs_size,
 int sctp_connectx2(int fd, struct sockaddr *addrs, int addrcnt,
 		      sctp_assoc_t *id)
 {
-	socklen_t addrs_size = __connectx_addrsize(addrs, addrcnt);
+	int addrs_size = __connectx_addrsize(addrs, addrcnt);
 
 	if (addrs_size < 0)
 		return addrs_size;
@@ -128,7 +128,7 @@ int sctp_connectx2(int fd, struct sockaddr *addrs, int addrcnt,
 int sctp_connectx3(int fd, struct sockaddr *addrs, int addrcnt,
 		      sctp_assoc_t *id)
 {
-	socklen_t addrs_size = __connectx_addrsize(addrs, addrcnt);
+	int addrs_size = __connectx_addrsize(addrs, addrcnt);
 	int status;
 	struct sctp_getaddrs_old param;
 	socklen_t opt_len = sizeof(param);
-- 
1.9.3




------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] Fix warning
  2015-01-09  2:16 [LTP] [PATCH] Fix warning Zeng Linggang
@ 2015-01-26 16:31 ` Cyril Hrubis
       [not found]   ` <1422526845-27822-1-git-send-email-zenglg.jy@cn.fujitsu.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2015-01-26 16:31 UTC (permalink / raw)
  To: Zeng Linggang; +Cc: ltp-list

Hi!
> diff --git a/testcases/kernel/io/disktest/dump.c b/testcases/kernel/io/disktest/dump.c
> index eef119b..ffb5ce1 100644
> --- a/testcases/kernel/io/disktest/dump.c
> +++ b/testcases/kernel/io/disktest/dump.c
> @@ -173,7 +173,7 @@ int dump_data(FILE * stream, const char *buff, const size_t buff_siz,
>  
>  int do_dump(child_args_t * args)
>  {
> -	size_t NumBytes = 0;
> +	ssize_t NumBytes = 0;
>  	OFF_T TargetLBA, TotalBytes = 0;
>  	char *buff;
>  	fd_t fd;
> diff --git a/testcases/kernel/syscalls/munmap/munmap01.c b/testcases/kernel/syscalls/munmap/munmap01.c
> index 67eb74b..0c16f34 100644
> --- a/testcases/kernel/syscalls/munmap/munmap01.c
> +++ b/testcases/kernel/syscalls/munmap/munmap01.c
> @@ -152,7 +152,7 @@ int main(int ac, char **av)
>   */

This one is OK.

>  void setup(void)
>  {
> -	size_t page_sz;		/* system page size */
> +	int page_sz;
>  
>  	tst_sig(NOFORK, DEF_HANDLER, cleanup);


Here we can drop the check, because getpagesize() cannot fail.

> diff --git a/testcases/kernel/syscalls/munmap/munmap02.c b/testcases/kernel/syscalls/munmap/munmap02.c
> index 2832e24..b7eca33 100644
> --- a/testcases/kernel/syscalls/munmap/munmap02.c
> +++ b/testcases/kernel/syscalls/munmap/munmap02.c
> @@ -83,7 +83,7 @@
>  char *TCID = "munmap02";
>  int TST_TOTAL = 1;
>  
> -size_t page_sz;			/* system page size */
> +static int page_sz;
>  char *addr;			/* addr of memory mapped region */
>  int fildes;			/* file descriptor for tempfile */
>  unsigned int map_len;		/* length of the region to be mapped */

Here as well.


> diff --git a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c
> index 42ed804..6a45ebf 100644
> --- a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c
> +++ b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages01.c
> @@ -92,7 +92,7 @@
>  /* Test case defines */
>  #define WINDOW_START 0x48000000
>  
> -size_t page_sz;
> +static int page_sz;

> diff --git a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c
> index d00d7ce..003ac77 100644
> --- a/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c
> +++ b/testcases/kernel/syscalls/remap_file_pages/remap_file_pages02.c
> @@ -83,7 +83,7 @@
>  /* Test case defines */
>  #define WINDOW_START 0x48000000
>  
> -size_t page_sz;
> +static int page_sz;

These two as well.

We may also remove sizeof(char) because that is 1 by the definition of
the C language.

>  size_t page_words;
>  size_t cache_pages;
>  size_t cache_sz;
> diff --git a/testcases/network/tcp_cmds/perf_lan/pingpong.c b/testcases/network/tcp_cmds/perf_lan/pingpong.c
> index d02b552..746891e 100644
> --- a/testcases/network/tcp_cmds/perf_lan/pingpong.c
> +++ b/testcases/network/tcp_cmds/perf_lan/pingpong.c
> @@ -207,7 +207,7 @@ int main(int argc, char *argv[])
>  		while (1) {
>  
>  			len = sizeof(packet);
> -			size_t cc;
> +			ssize_t cc;
>  			socklen_t fromlen;
>  
>  			/* Receive packet from socket */
> @@ -239,7 +239,7 @@ int echopkt(int datalen, int npackets)
>  	static uint8_t outpack[MAXPACKET];
>  	register icmp_t *icp = (icmp_t *) outpack;
>  	int i;
> -	size_t cc;
> +	ssize_t cc;
>  
>  	register u_char *datap = &outpack[8];
>  
> @@ -282,7 +282,7 @@ int echopkt(int datalen, int npackets)
>  		if (i < 0 || i != cc) {
>  			if (i < 0)
>  				perror("sendto");
> -			tst_resm(TINFO, "wrote %s %d chars, ret=%d",
> +			tst_resm(TINFO, "wrote %s %zd chars, ret=%d",
>  				 hostname, cc, i);
>  			fflush(stdout);
>  		}

This one looks OK.

> diff --git a/utils/sctp/lib/connectx.c b/utils/sctp/lib/connectx.c
> index b691f6b..cf8f5ed 100644
> --- a/utils/sctp/lib/connectx.c
> +++ b/utils/sctp/lib/connectx.c
> @@ -66,7 +66,7 @@ static int __connectx_addrsize(const struct sockaddr *addrs,
>  
>  int __sctp_connectx(int fd, struct sockaddr *addrs, int addrcnt)
>  {
> -	socklen_t addrs_size = __connectx_addrsize(addrs, addrcnt);
> +	int addrs_size = __connectx_addrsize(addrs, addrcnt);
>  
>  	if (addrs_size < 0)
>  		return addrs_size;
> @@ -117,7 +117,7 @@ static int __connectx(int fd, struct sockaddr *addrs, socklen_t addrs_size,
>  int sctp_connectx2(int fd, struct sockaddr *addrs, int addrcnt,
>  		      sctp_assoc_t *id)
>  {
> -	socklen_t addrs_size = __connectx_addrsize(addrs, addrcnt);
> +	int addrs_size = __connectx_addrsize(addrs, addrcnt);
>  
>  	if (addrs_size < 0)
>  		return addrs_size;
> @@ -128,7 +128,7 @@ int sctp_connectx2(int fd, struct sockaddr *addrs, int addrcnt,
>  int sctp_connectx3(int fd, struct sockaddr *addrs, int addrcnt,
>  		      sctp_assoc_t *id)
>  {
> -	socklen_t addrs_size = __connectx_addrsize(addrs, addrcnt);
> +	int addrs_size = __connectx_addrsize(addrs, addrcnt);
>  	int status;
>  	struct sctp_getaddrs_old param;
>  	socklen_t opt_len = sizeof(param);

This is also OK.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH v2] Fix warning
       [not found]   ` <1422526845-27822-1-git-send-email-zenglg.jy@cn.fujitsu.com>
@ 2015-01-29 12:09     ` Cyril Hrubis
  0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2015-01-29 12:09 UTC (permalink / raw)
  To: Zeng Linggang; +Cc: ltp-list

Hi!
Pushed, thanks.
-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-29 12:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-09  2:16 [LTP] [PATCH] Fix warning Zeng Linggang
2015-01-26 16:31 ` Cyril Hrubis
     [not found]   ` <1422526845-27822-1-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-01-29 12:09     ` [LTP] [PATCH v2] " Cyril Hrubis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.