From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481AbbA2T5X (ORCPT ); Thu, 29 Jan 2015 14:57:23 -0500 Received: from mail-ig0-f179.google.com ([209.85.213.179]:52322 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754926AbbA2T5U (ORCPT ); Thu, 29 Jan 2015 14:57:20 -0500 Date: Thu, 29 Jan 2015 11:57:35 -0800 From: Andrew Shewmaker To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Rik van Riel , Konstantin Khlebnikov , stable@vger.kernel.org Subject: Re: [PATCH] mm: fix arithmetic overflow in __vm_enough_memory() Message-ID: <20150129195735.GA9331@scruffy> References: <1422536763-31325-1-git-send-email-klamm@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422536763-31325-1-git-send-email-klamm@yandex-team.ru> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 29, 2015 at 04:06:03PM +0300, Roman Gushchin wrote: > I noticed, that "allowed" can easily overflow by falling below 0, > because (total_vm / 32) can be larger than "allowed". The problem > occurs in OVERCOMMIT_NONE mode. > > In this case, a huge allocation can success and overcommit the system > (despite OVERCOMMIT_NONE mode). All subsequent allocations will fall > (system-wide), so system become unusable. > > The problem was masked out by commit c9b1d0981fcc > ("mm: limit growth of 3% hardcoded other user reserve"), > but it's easy to reproduce it on older kernels: > 1) set overcommit_memory sysctl to 2 > 2) mmap() large file multiple times (with VM_SHARED flag) > 3) try to malloc() large amount of memory > > It also can be reproduced on newer kernels, but miss-configured > sysctl_user_reserve_kbytes is required. > > Fix this issue by switching to signed arithmetic here. > > Signed-off-by: Roman Gushchin > Cc: Andrew Morton > Cc: Andrew Shewmaker > Cc: Rik van Riel > Cc: Konstantin Khlebnikov > Cc: stable@vger.kernel.org > --- > mm/mmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 7f684d5..5aa8dfe 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -152,7 +152,7 @@ EXPORT_SYMBOL_GPL(vm_memory_committed); > */ > int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > { > - unsigned long free, allowed, reserve; > + long free, allowed, reserve; > > VM_WARN_ONCE(percpu_counter_read(&vm_committed_as) < > -(s64)vm_committed_as_batch * num_online_cpus(), > @@ -220,7 +220,7 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > */ > if (mm) { > reserve = sysctl_user_reserve_kbytes >> (PAGE_SHIFT - 10); > - allowed -= min(mm->total_vm / 32, reserve); > + allowed -= min((long)mm->total_vm / 32, reserve); > } > > if (percpu_counter_read_positive(&vm_committed_as) < allowed) > -- > 2.1.0 > Makes sense to me. Please fix mm/nommu.c also. If a caller passes in a big negative value for pages, then vm_acct_memory() would decrement vm_committed_as, possibly causing percpu_counter_read_positive(&vm_committed_as) and __vm_enough_memory to return 0. Maybe that's okay? Callers won't be passing in a negative pages anyway. Is there a reason to let them, though? -Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 29 Jan 2015 11:57:35 -0800 From: Andrew Shewmaker To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Rik van Riel , Konstantin Khlebnikov , stable@vger.kernel.org Subject: Re: [PATCH] mm: fix arithmetic overflow in __vm_enough_memory() Message-ID: <20150129195735.GA9331@scruffy> References: <1422536763-31325-1-git-send-email-klamm@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422536763-31325-1-git-send-email-klamm@yandex-team.ru> Sender: owner-linux-mm@kvack.org List-ID: On Thu, Jan 29, 2015 at 04:06:03PM +0300, Roman Gushchin wrote: > I noticed, that "allowed" can easily overflow by falling below 0, > because (total_vm / 32) can be larger than "allowed". The problem > occurs in OVERCOMMIT_NONE mode. > > In this case, a huge allocation can success and overcommit the system > (despite OVERCOMMIT_NONE mode). All subsequent allocations will fall > (system-wide), so system become unusable. > > The problem was masked out by commit c9b1d0981fcc > ("mm: limit growth of 3% hardcoded other user reserve"), > but it's easy to reproduce it on older kernels: > 1) set overcommit_memory sysctl to 2 > 2) mmap() large file multiple times (with VM_SHARED flag) > 3) try to malloc() large amount of memory > > It also can be reproduced on newer kernels, but miss-configured > sysctl_user_reserve_kbytes is required. > > Fix this issue by switching to signed arithmetic here. > > Signed-off-by: Roman Gushchin > Cc: Andrew Morton > Cc: Andrew Shewmaker > Cc: Rik van Riel > Cc: Konstantin Khlebnikov > Cc: stable@vger.kernel.org > --- > mm/mmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 7f684d5..5aa8dfe 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -152,7 +152,7 @@ EXPORT_SYMBOL_GPL(vm_memory_committed); > */ > int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > { > - unsigned long free, allowed, reserve; > + long free, allowed, reserve; > > VM_WARN_ONCE(percpu_counter_read(&vm_committed_as) < > -(s64)vm_committed_as_batch * num_online_cpus(), > @@ -220,7 +220,7 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > */ > if (mm) { > reserve = sysctl_user_reserve_kbytes >> (PAGE_SHIFT - 10); > - allowed -= min(mm->total_vm / 32, reserve); > + allowed -= min((long)mm->total_vm / 32, reserve); > } > > if (percpu_counter_read_positive(&vm_committed_as) < allowed) > -- > 2.1.0 > Makes sense to me. Please fix mm/nommu.c also. If a caller passes in a big negative value for pages, then vm_acct_memory() would decrement vm_committed_as, possibly causing percpu_counter_read_positive(&vm_committed_as) and __vm_enough_memory to return 0. Maybe that's okay? Callers won't be passing in a negative pages anyway. Is there a reason to let them, though? -Andrew -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org