Re: [PATCH 2/2] DT: leds: Add led-sources property

From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	kyungmin.park@samsung.com, b.zolnierkie@samsung.com,
	cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi,
	s.nawrocki@samsung.com, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 2/2] DT: leds: Add led-sources property
Date: Thu, 29 Jan 2015 21:28:24 +0100	[thread overview]
Message-ID: <20150129202824.GA3962@amd> (raw)
In-Reply-To: <54CA49F8.2030501@samsung.com>

On Thu 2015-01-29 15:55:52, Jacek Anaszewski wrote:
> Hi Rob,
> 
> Have we achieved consensus concerning this patch?
> If so, can you give your ack?

I'm not Rob, but:

Acked-by: Pavel Machek <pavel@ucw.cz>

> On 01/27/2015 09:07 AM, Jacek Anaszewski wrote:
> >Add a property for defining device outputs the LED
> >represented by the DT child node is connected to.
> >
> >Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> >Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> >Cc: Bryan Wu <cooloney@gmail.com>
> >Cc: Richard Purdie <rpurdie@rpsys.net>
> >Cc: Rob Herring <robh+dt@kernel.org>
> >Cc: Pawel Moll <pawel.moll@arm.com>
> >Cc: Mark Rutland <mark.rutland@arm.com>
> >Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> >Cc: Kumar Gala <galak@codeaurora.org>
> >Cc: devicetree@vger.kernel.org
> >---
> >  Documentation/devicetree/bindings/leds/common.txt |   16 +++++++++++++++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> >
> >diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
> >index a2c3f7a..34811c5 100644
> >--- a/Documentation/devicetree/bindings/leds/common.txt
> >+++ b/Documentation/devicetree/bindings/leds/common.txt
> >@@ -1,6 +1,19 @@
> >  Common leds properties.
> >
> >+LED and flash LED devices provide the same basic functionality as current
> >+regulators, but extended with LED and flash LED specific features like
> >+blinking patterns, flash timeout, flash faults and external flash strobe mode.
> >+
> >+Many LED devices expose more than one current output that can be connected
> >+to one or more discrete LED component. Since the arrangement of connections
> >+can influence the way of the LED device initialization, the LED components
> >+have to be tightly coupled with the LED device binding. They are represented
> >+by child nodes of the parent LED device binding.
> >+
> >  Optional properties for child nodes:
> >+- led-sources : List of device current outputs the LED is connected to. The
> >+		outputs are identified by the numbers that must be defined
> >+		in the LED device binding documentation.
> >  - label : The label for this LED.  If omitted, the label is
> >    taken from the node name (excluding the unit address).
> >
> >@@ -33,7 +46,8 @@ system-status {
> >
> >  camera-flash {
> >  	label = "Flash";
> >+	led-sources = <0>, <1>;
> >  	max-microamp = <50000>;
> >  	flash-max-microamp = <320000>;
> >  	flash-timeout-us = <500000>;
> >-}
> >+};
> >
> 
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html