From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH] xen/balloon: cancel ballooning if adding
 new memory failed
Date: Thu, 29 Jan 2015 21:35:56 +0100
Message-ID: <20150129203556.GD3473@olila.local.net-space.pl>
References: <1409593964-15144-1-git-send-email-david.vrabel@citrix.com>
	<1422538593.5198.1.camel@citrix.com> <54CA7580.4090409@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <daniel.kiper@oracle.com>) id 1YGvp2-0000zy-Bz
	for xen-devel@lists.xenproject.org; Thu, 29 Jan 2015 20:36:16 +0000
Content-Disposition: inline
In-Reply-To: <54CA7580.4090409@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Jan 29, 2015 at 06:01:36PM +0000, David Vrabel wrote:
> On 29/01/15 13:36, Ian Campbell wrote:
> > On Mon, 2014-09-01 at 18:52 +0100, David Vrabel wrote:
> >> If the balloon driver is adding additional memory regions to the
> >> balloon and add_memory() fails it will likely continuously fail so
> >> cancel the balloon operation.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776448 and
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1304001 seem to
> > suggest this should be a candidate for stable backports?
>
> It's up to the distro kernel maintainer to request it if they think it
> is important.  It's a harmless message with no side effects so I don't
> think it qualifies.

It pollutes system logs, makes unnecessary confusion and from time to time
noise on various lists. Fix is trivial, so, why not. However, as David said
this is up to stable kernel maintainer.

If yes you should also backport commit fd8b79511349efd1f0decea920f61b93acb34a75
(xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered).
IIRC, both (trivial) patches are needed to fix this issue.

Daniel