From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758479AbbA2Vjq (ORCPT ); Thu, 29 Jan 2015 16:39:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38597 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757108AbbA2Vjn (ORCPT ); Thu, 29 Jan 2015 16:39:43 -0500 Date: Thu, 29 Jan 2015 15:39:39 -0600 From: Josh Poimboeuf To: Steven Rostedt Cc: Satoru Takeuchi , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] ktest: console pty support Message-ID: <20150129213939.GA20952@treble.redhat.com> References: <20150129154441.1b248e93@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150129154441.1b248e93@gandalf.local.home> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 29, 2015 at 03:44:41PM -0500, Steven Rostedt wrote: > On Wed, 28 Jan 2015 13:38:37 -0600 > Josh Poimboeuf wrote: > > > These patches can be applied on top of yesterday's "ktest: restore tty settings > > after closing console" patch. They create a pty pair for the console to > > prevent the console child process from messing up ktest's tty settings. > > > > v2 changes: > > - rebased onto the stty save/restore patch > > - added a patch to enable user input to the console > > > > Josh Poimboeuf (2): > > ktest: give console process a dedicated tty > > ktest: enable user input to the console > > > > tools/testing/ktest/ktest.pl | 117 ++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 93 insertions(+), 24 deletions(-) > > > > OK, I applied these and been using ktest since. But after one of my > tests failed (got a bug report), I had no console. I think there's a > die someplace that does not put everything back. > > Think you could find out where? Can you tell if it died via dodie()? Looks like that wouldn't clean up the stty settings. -- Josh