From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1YH6M4-0002fq-Mp
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 02:51:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1YH6Lz-0002J7-My
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 02:51:04 -0500
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:33213)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1YH6Lz-0002J2-2Y
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 02:50:59 -0500
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Fri, 30 Jan 2015 13:20:56 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id 8961A3940049
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 13:20:53 +0530 (IST)
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay05.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t0U7orIl63307920
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 13:20:53 +0530
Received: from d28av04.in.ibm.com (localhost [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t0U7oqqc024650
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2015 13:20:52 +0530
Date: Fri, 30 Jan 2015 13:20:49 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20150130075049.GC24041@in.ibm.com>
References: <1420697420-16053-1-git-send-email-bharata@linux.vnet.ibm.com>
	<1420697420-16053-6-git-send-email-bharata@linux.vnet.ibm.com>
	<20150129011609.GP14681@voom>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150129011609.GP14681@voom>
Subject: Re: [Qemu-devel] [RFC PATCH v1 05/13] spapr: Support ibm,
 lrdr-capacity device tree property
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: imammedo@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

On Thu, Jan 29, 2015 at 12:16:09PM +1100, David Gibson wrote:
> On Thu, Jan 08, 2015 at 11:40:12AM +0530, Bharata B Rao wrote:
> > -int spapr_rtas_device_tree_setup(void *fdt, hwaddr rtas_addr,
> > -                                 hwaddr rtas_size)
> > +int spapr_rtas_device_tree_setup(sPAPREnvironment *spapr, void *fdt,
> > +                                 hwaddr rtas_addr, hwaddr rtas_size)
> >  {
> >      int ret;
> >      int i;
> > +    uint32_t lrdr_capacity[5];
> >  
> >      ret = fdt_add_mem_rsv(fdt, rtas_addr, rtas_size);
> >      if (ret < 0) {
> > @@ -604,6 +606,28 @@ int spapr_rtas_device_tree_setup(void *fdt, hwaddr rtas_addr,
> >          }
> >  
> >      }
> > +
> > +    ret = qemu_fdt_setprop_cell(fdt, "/rtas", "#address-cells", 0x2);
> > +    if (ret < 0) {
> > +        fprintf(stderr, "Couldn't add #address-cells rtas property\n");
> > +    }
> > +
> > +    ret = qemu_fdt_setprop_cell(fdt, "/rtas", "#size-cells", 0x2);
> > +    if (ret < 0) {
> > +        fprintf(stderr, "Couldn't add #size-cells rtas property\n");
> > +    }
> 
> It's not clear what adding #address-cells and #size-cells has to do
> with this, and these properties generally don't make sense on a node
> without children.

Yes, those aren't needed, will remove them.

Regards,
Bharata.