From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8PA-0007Uw-AE for qemu-devel@nongnu.org; Fri, 30 Jan 2015 05:02:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH8P5-0001tu-IC for qemu-devel@nongnu.org; Fri, 30 Jan 2015 05:02:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH8P5-0001tk-B1 for qemu-devel@nongnu.org; Fri, 30 Jan 2015 05:02:19 -0500 Date: Fri, 30 Jan 2015 10:02:12 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150130100212.GF2370@work-vm> References: <1422543997-22808-1-git-send-email-dgilbert@redhat.com> <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <20150129152255.GC2391@work-vm> <54CB5469.80806@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CB5469.80806@redhat.com> Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 29/01/2015 16:22, Dr. David Alan Gilbert wrote: > > I'm a bit worried about whether starting an incoming migrate afterwards is > > different in any subtle way. I can see there are a handful of devices that > > have 'runstate_check(RUN_STATE_INMIGRATE)' calls in, and thus I'm not sure > > that starting a paused VM and then flipping to RUN_STATE_INMIGRATE would > > be quite the same. > > Ouch, you're right. Especially BDRV_O_INCOMING is scary. Yes; I've not got a clue what it's effect is, but given it's glued into the block code I'm sure that breaking it will be subtle and nasty. I'm also reasonably sure it's probably going to do something different in the loadvm case which is probably unintended. Dave > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK