From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:34675 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010822AbbA3KS43gXKg (ORCPT ); Fri, 30 Jan 2015 11:18:56 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id F363B69CB1158 for ; Fri, 30 Jan 2015 10:18:46 +0000 (GMT) Message-ID: <54CB5A86.3010903@imgtec.com> Date: Fri, 30 Jan 2015 10:18:46 +0000 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH RFC v2 67/70] MIPS: kernel: process: Do not allow FR=0 on MIPS R6 References: <1421405389-15512-1-git-send-email-markos.chandras@imgtec.com> <1421405389-15512-68-git-send-email-markos.chandras@imgtec.com> <20150129231340.GI6116@NP-P-BURTON> In-Reply-To: <20150129231340.GI6116@NP-P-BURTON> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Paul Burton Cc: linux-mips@linux-mips.org, Matthew Fortune Message-ID: <20150130101846.1lef_L50h4UXo6sNBmK5lH5itZVDQ3dqzW5TN1qVMcM@z> On 01/29/2015 11:13 PM, Paul Burton wrote: > On Fri, Jan 16, 2015 at 10:49:46AM +0000, Markos Chandras wrote: >> A prctl() call to set FR=0 for MIPS R6 should not be allowed >> since FR=1 is the only option for R6 cores. >> >> Cc: Paul Burton >> Cc: Matthew Fortune >> Signed-off-by: Markos Chandras >> --- >> arch/mips/include/asm/fpu.h | 3 ++- >> arch/mips/kernel/process.c | 4 ++++ >> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/mips/include/asm/fpu.h b/arch/mips/include/asm/fpu.h >> index 994d21939676..b96d9d327626 100644 >> --- a/arch/mips/include/asm/fpu.h >> +++ b/arch/mips/include/asm/fpu.h >> @@ -68,7 +68,8 @@ static inline int __enable_fpu(enum fpu_mode mode) >> goto fr_common; >> >> case FPU_64BIT: >> -#if !(defined(CONFIG_CPU_MIPS32_R2) || defined(CONFIG_64BIT)) >> +#if !(defined(CONFIG_CPU_MIPS32_R2) || defined(CONFIG_CPU_MIPS32_R6) \ >> + || defined(CONFIG_64BIT)) > > Hi Markos, > > This change really seems like a separate one, since it has nothing to do > with the prctl or disallowing FR=1, but rather with allowing FR=1 on r6. > > Thanks, > Paul Thanks I will move it to a separate patch -- markos