From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 30 Jan 2015 11:04:19 +0100 Subject: [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout In-Reply-To: <1422601834.4846.2.camel@synopsys.com> References: <1421158224-11910-1-git-send-email-abrodkin@synopsys.com> <20150116211628.GG8425@amd> <1422601834.4846.2.camel@synopsys.com> Message-ID: <201501301104.19590.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, January 30, 2015 at 08:10:34 AM, Alexey Brodkin wrote: > Hi Marek, Tom, > > On Fri, 2015-01-16 at 22:16 +0100, Pavel Machek wrote: > > On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote: > > > If for some reason DMA module fails to reset user oserves only this: > > > --->--- > > > # dhcp > > > Trying dwmac.e0018000 > > > FAIL > > > --->--- > > > > > > This message makes not much sense. > > > With proposed change error message will be more helpful: > > > --->--- > > > # dhcp > > > Trying dwmac.e0018000 > > > DMA reset timeout > > > FAIL > > > --->--- > > > > > > For example user may do power toggle to recover board functionality. > > > > > > Signed-off-by: Alexey Brodkin > > > Cc: Chin Liang See > > > Cc: Dinh Nguyen > > > Cc: Albert Aribaud > > > Cc: Tom Rini > > > Cc: Wolfgang Denk > > > > Acked-by: Pavel Machek > > Any chance for this trivial change to be applied? Joe, can you please pick this ? Best regards, Marek Vasut