From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756489AbbA3MKj (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Jan 2015 07:10:39 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:18747 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752160AbbA3MKi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Jan 2015 07:10:38 -0500
Date: Fri, 30 Jan 2015 15:10:27 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Fred Akers <knivey@botops.net>
Subject: Re: [PATCH v2] staging: comedi: drivers: addi_apci_3501: Removed
 variables that is never used
Message-ID: <20150130121027.GX6456@mwanda>
References: <1422570895-9239-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
 <54CB5D18.8020001@mev.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54CB5D18.8020001@mev.co.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 30, 2015 at 10:29:44AM +0000, Ian Abbott wrote:
> >@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> >  	ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> >  	ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
> >  	outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> >-	i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
> >+	inl(dev->iobase + APCI3501_TIMER_STATUS_REG);
> >
> >  	return IRQ_HANDLED;
> >  }
> >
> 
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

Ian, is the inl() really needed?  Richard did the conservative thing,
but if we knew we could delete the inl() that would be nice.

regards,
dan carpenter