From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YHBnw-000075-9F
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 08:40:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YHBno-0002Y4-HZ
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 08:40:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39505)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YHBno-0002WJ-AE
	for qemu-devel@nongnu.org; Fri, 30 Jan 2015 08:40:04 -0500
Date: Fri, 30 Jan 2015 14:39:55 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150130133955.GB24537@noname.redhat.com>
References: <54CB3BB4.80406@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54CB3BB4.80406@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] quorum: don't share qiov
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: qemu-devl <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben:
> If the child touches qiov->iov, it will cause unexpected results.
> 
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

Any specific child you're thinking of?

I think children are not supposed to modify their qiov (which would also
fail for init_external qiovs). Perhaps we should have made it const.

Kevin