All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: use driver internal struct
Date: Fri, 30 Jan 2015 12:58:33 -0200	[thread overview]
Message-ID: <20150130145833.GH30820@joana> (raw)
In-Reply-To: <1422603782-29989-2-git-send-email-jy0922.shim@samsung.com>

Hi Joonyoung,

2015-01-30 Joonyoung Shim <jy0922.shim@samsung.com>:

> Use driver internal struct as argument instead of struct exynos_drm_crtc
> except functions of exynos_drm_crtc_ops and instead of struct
> exynos_drm_display except functions of exynos_drm_display_ops.
> 
> It can reduce unnecessary variable declaration.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c  | 14 ++++-------
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 43 +++++++++++++-------------------
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c | 19 ++++++--------
>  drivers/gpu/drm/exynos/exynos_hdmi.c     | 12 ++++-----
>  drivers/gpu/drm/exynos/exynos_mixer.c    | 26 ++++++++-----------
>  5 files changed, 47 insertions(+), 67 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-01-30 14:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  7:43 [PATCH] drm/exynos: fix wrong pipe calculation for crtc Joonyoung Shim
2015-01-30  7:43 ` [PATCH] drm/exynos: use driver internal struct Joonyoung Shim
2015-01-30 14:58   ` Gustavo Padovan [this message]
2015-02-04  7:17   ` Inki Dae
2015-01-30 14:56 ` [PATCH] drm/exynos: fix wrong pipe calculation for crtc Gustavo Padovan
2015-02-04  7:13 ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150130145833.GH30820@joana \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jy0922.shim@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.