From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v6 6/8] input: touchscreen: imx25 tcq driver Date: Fri, 30 Jan 2015 10:57:21 -0800 Message-ID: <20150130185721.GA11695@dtor-ws> References: <1422540556-14828-1-git-send-email-mpa@pengutronix.de> <1422540556-14828-7-git-send-email-mpa@pengutronix.de> <54CA4320.4030607@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <54CA4320.4030607@gmail.com> Sender: linux-input-owner@vger.kernel.org To: Varka Bhadram Cc: Markus Pargmann , Shawn Guo , Samuel Ortiz , Jonathan Cameron , Fabio Estevam , Peter Meerwald , Hartmut Knaack , Denis Carikli , Eric =?iso-8859-1?Q?B=E9nard?= , Sascha Hauer , linux-arm-kernel@lists.infradead.org, Lee Jones , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, Lars-Peter Clausen , devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org On Thu, Jan 29, 2015 at 07:56:40PM +0530, Varka Bhadram wrote: > Hi, > > On Thursday 29 January 2015 07:39 PM, Markus Pargmann wrote: > >This is a driver for the imx25 ADC/TSC module. It controls the > >touchscreen conversion queue and creates a touchscreen input device. > >The driver currently only supports 4 wire touchscreens. The driver uses > >a simple conversion queue of precharge, touch detection, X measurement, > >Y measurement, precharge and another touch detection. > > > >This driver uses the regmap from the parent to setup some touch specific > >settings in the core driver and setup a idle configuration with touch > >detection. > > > >Signed-off-by: Markus Pargmann > >Signed-off-by: Denis Carikli > >Acked-by: Dmitry Torokhov > >Signed-off-by: Markus Pargmann > >--- > > drivers/input/touchscreen/Kconfig | 6 + > > drivers/input/touchscreen/Makefile | 1 + > > drivers/input/touchscreen/fsl-imx25-tcq.c | 587 ++++++++++++++++++++++++++++++ > > 3 files changed, 594 insertions(+) > > create mode 100644 drivers/input/touchscreen/fsl-imx25-tcq.c > > > (...) > > >+ ret = request_threaded_irq(priv->irq, mx25_tcq_irq, mx25_tcq_irq_thread, > >+ IRQF_ONESHOT, pdev->name, priv); > > We can use devres API for request_thread_irq()... > > >+ if (ret) { > >+ dev_err(dev, "Failed requesting IRQ\n"); > >+ goto err_clk_unprepare; > >+ } > >+ > >+ ret = mx25_tcq_init(priv); > >+ if (ret) { > >+ dev_err(dev, "Failed to init tcq\n"); > >+ goto error_free_irq; > >+ } > >+ > >+ platform_set_drvdata(pdev, priv); > >+ > >+ return 0; > >+ > >+error_free_irq: > >+ free_irq(priv->irq, priv); > > This is not required if we use devres API Yes it does - you do not really want to stop clocks in the middle of servicing interrupt. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Fri, 30 Jan 2015 10:57:21 -0800 Subject: [PATCH v6 6/8] input: touchscreen: imx25 tcq driver In-Reply-To: <54CA4320.4030607@gmail.com> References: <1422540556-14828-1-git-send-email-mpa@pengutronix.de> <1422540556-14828-7-git-send-email-mpa@pengutronix.de> <54CA4320.4030607@gmail.com> Message-ID: <20150130185721.GA11695@dtor-ws> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 29, 2015 at 07:56:40PM +0530, Varka Bhadram wrote: > Hi, > > On Thursday 29 January 2015 07:39 PM, Markus Pargmann wrote: > >This is a driver for the imx25 ADC/TSC module. It controls the > >touchscreen conversion queue and creates a touchscreen input device. > >The driver currently only supports 4 wire touchscreens. The driver uses > >a simple conversion queue of precharge, touch detection, X measurement, > >Y measurement, precharge and another touch detection. > > > >This driver uses the regmap from the parent to setup some touch specific > >settings in the core driver and setup a idle configuration with touch > >detection. > > > >Signed-off-by: Markus Pargmann > >Signed-off-by: Denis Carikli > >Acked-by: Dmitry Torokhov > >Signed-off-by: Markus Pargmann > >--- > > drivers/input/touchscreen/Kconfig | 6 + > > drivers/input/touchscreen/Makefile | 1 + > > drivers/input/touchscreen/fsl-imx25-tcq.c | 587 ++++++++++++++++++++++++++++++ > > 3 files changed, 594 insertions(+) > > create mode 100644 drivers/input/touchscreen/fsl-imx25-tcq.c > > > (...) > > >+ ret = request_threaded_irq(priv->irq, mx25_tcq_irq, mx25_tcq_irq_thread, > >+ IRQF_ONESHOT, pdev->name, priv); > > We can use devres API for request_thread_irq()... > > >+ if (ret) { > >+ dev_err(dev, "Failed requesting IRQ\n"); > >+ goto err_clk_unprepare; > >+ } > >+ > >+ ret = mx25_tcq_init(priv); > >+ if (ret) { > >+ dev_err(dev, "Failed to init tcq\n"); > >+ goto error_free_irq; > >+ } > >+ > >+ platform_set_drvdata(pdev, priv); > >+ > >+ return 0; > >+ > >+error_free_irq: > >+ free_irq(priv->irq, priv); > > This is not required if we use devres API Yes it does - you do not really want to stop clocks in the middle of servicing interrupt. Thanks. -- Dmitry