From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754086AbbBAUTx (ORCPT ); Sun, 1 Feb 2015 15:19:53 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39071 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752087AbbBAUTu (ORCPT ); Sun, 1 Feb 2015 15:19:50 -0500 Date: Sun, 01 Feb 2015 12:19:48 -0800 (PST) Message-Id: <20150201.121948.998046471405758397.davem@davemloft.net> To: dwmw2@infradead.org Cc: mst@redhat.com, herbert@gondor.apana.org.au, eric.dumazet@gmail.com, jan.kiszka@siemens.com, paul.moore@hp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [PATCH] tun: orphan an skb on tx From: David Miller In-Reply-To: <1422797630.11044.32.camel@infradead.org> References: <1422789633.11044.18.camel@infradead.org> <20150201122611.GA8883@redhat.com> <1422797630.11044.32.camel@infradead.org> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sun, 01 Feb 2015 12:19:49 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Woodhouse Date: Sun, 01 Feb 2015 13:33:50 +0000 > Of course, now I'm looking closely at the path these packets take to > leave the box, it starts to offend me that they're being passed up to > userspace just to encrypt them (as DTLS or ESP) and then send them back > down to the kernel on a UDP socket. The kernel already knows how to > {en,de}crypt ESP, and do the sequence number checking on incoming > packets. It's funny, I thought we had an IPSEC stack.... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI0zr-0000Mo-Hr for qemu-devel@nongnu.org; Sun, 01 Feb 2015 15:19:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI0zo-0007Db-B5 for qemu-devel@nongnu.org; Sun, 01 Feb 2015 15:19:55 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:55963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI0zo-0007DA-5r for qemu-devel@nongnu.org; Sun, 01 Feb 2015 15:19:52 -0500 Date: Sun, 01 Feb 2015 12:19:48 -0800 (PST) Message-Id: <20150201.121948.998046471405758397.davem@davemloft.net> From: David Miller In-Reply-To: <1422797630.11044.32.camel@infradead.org> References: <1422789633.11044.18.camel@infradead.org> <20150201122611.GA8883@redhat.com> <1422797630.11044.32.camel@infradead.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dwmw2@infradead.org Cc: paul.moore@hp.com, herbert@gondor.apana.org.au, eric.dumazet@gmail.com, mst@redhat.com, jan.kiszka@siemens.com, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, netdev@vger.kernel.org From: David Woodhouse Date: Sun, 01 Feb 2015 13:33:50 +0000 > Of course, now I'm looking closely at the path these packets take to > leave the box, it starts to offend me that they're being passed up to > userspace just to encrypt them (as DTLS or ESP) and then send them back > down to the kernel on a UDP socket. The kernel already knows how to > {en,de}crypt ESP, and do the sequence number checking on incoming > packets. It's funny, I thought we had an IPSEC stack....