From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 18/18] Change mk/rte.app.mk to add fm10k lib into link Date: Mon, 2 Feb 2015 08:46:41 -0500 Message-ID: <20150202134641.GB21700@hmsreliant.think-freely.org> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <1422594454-11045-19-git-send-email-jing.d.chen@intel.com> <20150201005059.GC31443@localhost.localdomain> <4341B239C0EFF9468EE453F9E9F4604D016631DC@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Chen, Jing D" Return-path: Content-Disposition: inline In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D016631DC-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On Mon, Feb 02, 2015 at 08:10:17AM +0000, Chen, Jing D wrote: > Hi Neil, > > > -----Original Message----- > > From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org] > > Sent: Sunday, February 01, 2015 8:51 AM > > To: Chen, Jing D > > Cc: dev-VfR2kkLFssw@public.gmane.org > > Subject: Re: [dpdk-dev] [PATCH 18/18] Change mk/rte.app.mk to add fm10k > > lib into link > > > > On Fri, Jan 30, 2015 at 01:07:34PM +0800, Chen Jing D(Mark) wrote: > > > From: Jeff Shaw > > > > > > Signed-off-by: Jeff Shaw > > > Signed-off-by: Chen Jing D(Mark) > > > --- > > > mk/rte.app.mk | 4 ++++ > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > > > index 4294d9a..87d8763 100644 > > > --- a/mk/rte.app.mk > > > +++ b/mk/rte.app.mk > > > @@ -211,6 +211,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y) > > > LDLIBS += -lrte_pmd_i40e > > > endif > > > > > > +ifeq ($(CONFIG_RTE_LIBRTE_FM10K_PMD),y) > > > +LDLIBS += -lrte_pmd_fm10k > > > +endif > > > + > > > ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > > LDLIBS += -lrte_pmd_ixgbe > > > endif > > > -- > > > 1.7.7.6 > > > > > > > > This patch should be merged with patch 17, and patch 2, and placed at the > > end of > > your series to avoid a FTBFS issue > > My rationale is to make every single patch not to break the compile. So, I'd like to > add the binary library into compile and link in last 2 patches, after all the actual code > are patched. For Patch 2, I think you are right, maybe a better way is to move it as > patch "16". > > But I'm not sure whether I should merge these 3 together. You know, somebody may > not happy to see the changes in different directory to appear in single patch. > As Thomas notes, its fine to change multiple directories, its the functionality add and ability to compile that needs to be atomic to a commit. Neil > > Neil > >