From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965027AbbBBO0u (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Feb 2015 09:26:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38614 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755698AbbBBO0q (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Feb 2015 09:26:46 -0500
Date: Mon, 2 Feb 2015 15:26:34 +0100
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Nadav Amit <namit@cs.technion.ac.il>, Gleb Natapov <gleb@kernel.org>
Subject: Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()
Message-ID: <20150202142633.GA19731@potion.redhat.com>
References: <1422568135-28402-1-git-send-email-rkrcmar@redhat.com>
 <1422568135-28402-3-git-send-email-rkrcmar@redhat.com>
 <54CB4668.30909@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <54CB4668.30909@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2015-01-30 09:52+0100, Paolo Bonzini:
> On 29/01/2015 22:48, Radim Krčmář wrote:
> > The majority of this patch turns
> >   result = 0; if (CODE) result = 1; return result;
> > into
> >   return CODE;
> > because we return bool now.
> 
> Added a bunch of "!= 0" to avoid automagic conversion to bool.

(I haven't checked it earlier ... sorry.)

> > -		if (((logical_id >> 4) == (mda >> 0x4))
> > -		    && (logical_id & mda & 0xf))
> > -			result = 1;
> > -		break;
> > +		return ((logical_id >> 4) == (mda >> 4))
> > +		       && (logical_id & mda & 0xf);

was merged as

+		return ((logical_id >> 4) == (mda >> 4))
+		       && (logical_id & mda & 0xf) != 0;

but it has to be parenthesized ('&&' has lower precedence than '!=').