All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: talex5@gmail.com, Wei Liu <wei.liu2@citrix.com>,
	anil@recoil.org, stefano.stabellini@eu.citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, pooka@iki.fi,
	samuel.thibault@ens-lyon.org, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH 6/7] build system: stubdom targets now depends on mini-os target
Date: Mon, 2 Feb 2015 17:18:49 +0000	[thread overview]
Message-ID: <20150202171849.GB841@zion.uk.xensource.com> (raw)
In-Reply-To: <1422889425.4801.10.camel@citrix.com>

On Mon, Feb 02, 2015 at 03:03:45PM +0000, Ian Campbell wrote:
> On Mon, 2015-02-02 at 15:01 +0000, Ian Campbell wrote:
> > On Mon, 2015-02-02 at 12:59 +0000, Wei Liu wrote:
> > > Provide mini-os url and revision in Config.mk
> > > 
> > > Introduce Makefile.mini-os which contains mini-os specific targets.
> > 
> > I'm not sure it has enough content to warrant that, those two targets
> > could easily be inlined.
> > 
> > > +ifeq ($(wildcard $(MINI_OS)/Config.mk),)
> > > +$(error Please run `make mini-os-dir' in top-level directory)
> > > +endif
> > 
> > This makes me think that maybe my earlier suggestion to move the clone
> > under stubdom/ might be better done right away.
> > 
> > In fact, that would avoid the need to play tricks with renaming extras/
> > too, since you could build both for a commit.
> 
> Retracted after reponse to my earlier suggestion...
> 

I take it you're fine with the current arrangement now?

Wei.

> > 
> > Ian.
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
> 

  reply	other threads:[~2015-02-02 17:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 12:58 [PATCH 0/7] Split off mini-os to a separate tree Wei Liu
2015-02-02 12:58 ` [PATCH 1/7] stubdom: fix "make build" Wei Liu
2015-02-02 14:53   ` Ian Campbell
2015-02-02 22:11   ` Samuel Thibault
2015-02-02 12:58 ` [PATCH 2/7] Makefile: refactor build/clean/distclean targets Wei Liu
2015-02-02 14:54   ` Ian Campbell
2015-02-02 12:58 ` [PATCH 3/7] stubdom: don't look for mini-os source file during configure Wei Liu
2015-02-02 15:09   ` Ian Jackson
2015-02-02 15:27     ` Wei Liu
2015-02-02 12:59 ` [PATCH 4/7] git-checkout.sh: use "mkdir -p" Wei Liu
2015-02-02 14:58   ` Ian Campbell
2015-02-02 15:02     ` Ian Jackson
2015-02-02 15:05       ` Andrew Cooper
2015-02-02 15:02     ` Wei Liu
2015-02-02 12:59 ` [PATCH 5/7] Mini-OS: standalone build Wei Liu
2015-02-02 14:59   ` Ian Campbell
2015-02-02 12:59 ` [PATCH 6/7] build system: stubdom targets now depends on mini-os target Wei Liu
2015-02-02 15:01   ` Ian Campbell
2015-02-02 15:03     ` Ian Campbell
2015-02-02 17:18       ` Wei Liu [this message]
2015-02-03 11:31         ` Ian Campbell
2015-02-02 15:12     ` Wei Liu
2015-02-02 15:15       ` Ian Jackson
2015-02-02 15:25         ` Wei Liu
2015-02-02 12:59 ` [PATCH 7/7] Remove in-tree mini-os directory Wei Liu
2015-02-02 15:02   ` Ian Campbell
2015-02-02 14:50 ` [PATCH 0/7] Split off mini-os to a separate tree Ian Campbell
2015-02-02 14:59   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150202171849.GB841@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=anil@recoil.org \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=ian.jackson@eu.citrix.com \
    --cc=pooka@iki.fi \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=talex5@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.