From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC] libxl: set disk defaults in remove/destroy functions Date: Mon, 2 Feb 2015 18:13:00 +0000 Message-ID: <20150202181300.GB5530@zion.uk.xensource.com> References: <54C6CA4A.4040505@suse.com> <1422883633.19293.19.camel@citrix.com> <20150202163225.GB25824@zion.uk.xensource.com> <21711.42984.152730.493299@mariner.uk.xensource.com> <20150202180028.GA5530@zion.uk.xensource.com> <21711.48279.850469.343155@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <21711.48279.850469.343155@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Jim Fehlig , Wei Liu , Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Mon, Feb 02, 2015 at 06:06:15PM +0000, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"): > > On Mon, Feb 02, 2015 at 04:38:00PM +0000, Ian Jackson wrote: > > > libxl_device_disk_remove should definitely not require the caller to > > > do what xl currently does. > > > > I come up with something like this (only compile tested). > > Something like this perhaps, yes. Although it seems to have rather > too much similarity with parts of libxl__device_disk_from_xs_be... > I wanted to refactor those bits but I couldn't come up with a sensible function name. I'm particularly bad at naming things. :-( If you come up with a name I can factor those bits out. Wei. > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel