From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC v3 2/4] mfd: Add a new cell device for panel controlled by crystal cove pmic Date: Tue, 3 Feb 2015 14:05:48 +0100 Message-ID: <20150203130546.GF15068@ulmo.nvidia.com> References: <1421839093-7635-1-git-send-email-shobhit.kumar@intel.com> <1421839093-7635-3-git-send-email-shobhit.kumar@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1995705161==" Return-path: In-Reply-To: <1421839093-7635-3-git-send-email-shobhit.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shobhit Kumar Cc: Jani Nikula , Daniel Vetter , intel-gfx , dri-devel List-Id: dri-devel@lists.freedesktop.org --===============1995705161== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ni93GHxFvA+th69W" Content-Disposition: inline --ni93GHxFvA+th69W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 21, 2015 at 04:48:11PM +0530, Shobhit Kumar wrote: > On BYT-T configuration, panel enable/disable signals are routed through > PMIC. Add a cell device for the same. >=20 > Signed-off-by: Shobhit Kumar > --- > drivers/mfd/intel_soc_pmic_crc.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmi= c_crc.c > index c85e2ec..c8ccc24 100644 > --- a/drivers/mfd/intel_soc_pmic_crc.c > +++ b/drivers/mfd/intel_soc_pmic_crc.c > @@ -109,6 +109,9 @@ static struct mfd_cell crystal_cove_dev[] =3D { > { > .name =3D "crystal_cove_pmic", > }, > + { > + .name =3D "crystal_cove_panel", > + }, > }; > =20 > static struct regmap_config crystal_cove_regmap_config =3D { This doesn't look at all right. A PMIC doesn't typically contain a panel so this likely is a wrong description of the hardware. Is the datasheet for the Crystal Cove PMIC available somewhere? Google doesn't turn any- thing useful up. Thierry --ni93GHxFvA+th69W Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0MeqAAoJEN0jrNd/PrOhJpoP/0haX2oK3U6cvBnbabACb4Sq npBCasBme+d4O6krMPwwkRYyL/9eF/oH0wRFcG0hYuh1RjGql1U38hShTXgI+LBS NQh4GylQiaJVHBnPONj1HFIN6NI5tjzYxxghyRWzkTK/FY+3Qj3I90upfaYSOZ49 05FUc1NM1ben4ZpzLrY8RvDGZ30ofWtPcpB2W+9N+Joa055Mj1997veZ5AOT2tAd M78T1ACT1xuWoyRr4JEvfblGssYSQtYYopxbjKvYjMbHzhEvwBhrUMvWkct63rHv SYDy+JYRicOTujb3BdzqRgAtNVyj2W1k/Ou5V9n3A9Nz5CqoYu41ZV/mt7dYOuQq eY9fPUAzxmEPmKSMiFFvh4U6IHEG0p3mm6THq+rw7vskpTjuv+Pnl1/Z9/IlvfuO y7JjYQLGNkxCEJP8VraUnOXFwExNdabfEYCDSDdNHE34LK5gg/44lD+cAkkSfWZe sr4P+kaPTYb3YiHP94cAigDepZBwa3ck5xa0VoDbAK6wQKU/FvNIhsQ0RsD1bCz5 y4nzCpOXgVBnymeqa3ab7zHakhCSrskOH8JPpjL+2LGhMXpjmsAQYaPwWEPEXTpY 7KRCCiA3g5CqWlStFNocy2EYHuCtogsQ1fNbx2x7DUOrp64zu/4lMNQbbDvpBgRU +H2ZAH8Gfa/OiPIMT4a+ =BB2+ -----END PGP SIGNATURE----- --ni93GHxFvA+th69W-- --===============1995705161== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1995705161==--