From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH OSSTEST v5 9/9] mfi-common,
 make-flight: create XSM test jobs
Date: Tue, 3 Feb 2015 14:25:23 +0000
Message-ID: <20150203142523.GE23306@zion.uk.xensource.com>
References: <1422959786-22738-1-git-send-email-wei.liu2@citrix.com>
	<1422959786-22738-10-git-send-email-wei.liu2@citrix.com>
	<21712.54069.246717.10075@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <21712.54069.246717.10075@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, Feb 03, 2015 at 01:55:01PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs"):
> > Duplicate Debian PV and HVM test jobs for XSM testing.
> ...
> >  do_hvm_debian_tests() {
> > +  test_xsm=$(xenbranch_xsm_variants)
> 
> This variable needs to have a different name, with a plural init.
> "xsm_variants" perhaps ?  Or "xsms" ?  Ideally the loop control
> variable in the loops would be the singular form of the samename.
> 

Ack.

> > @@ -299,19 +308,26 @@ do_passthrough_tests () {
> >  }
> >  
> >  do_pv_debian_tests () {
> > -  # Basic PV Linux test with xl
> > -  for platform in '' `getplatforms $xenarch` ; do
> 
> This part is quite hard to review.  Can you perhaps provide a `git
> diff -b' ?
> 

Here is "git show -b" of my patch. Nb this patch is different in my tree
from this one posted here because I've modified it to adapt Ian C's and
your suggestions.

 do_pv_debian_tests () {
+  xsms=$(xenbranch_xsm_variants)
+
+  for xsm in $xsms ; do
     # Basic PV Linux test with xl
     for platform in '' `getplatforms $xenarch` ; do
+
+      # xsm test is not platform specific
+      if [ x$xsm = xtrue -a x$platform != x ]; then
+          continue
+      fi
+
       suffix=${platform:+-$platform}
       hostflags=${most_hostflags}${platform:+,platform-$platform}

       job_create_test test-$xenarch$kern-$dom0arch-xl$suffix test-debian xl \
                       $xenarch $dom0arch                                    \
+                      enable_xsm=$xsm                                       \
                       $debian_runvars all_hostflags=$hostflags
     done
+  done

+  for xsm in $xsms ; do
     job_create_test test-$xenarch$kern-$dom0arch-libvirt test-debian libvirt \
                     $xenarch $dom0arch                                       \
+                    enable_xsm=$xsm                                          \
                     $debian_runvars all_hostflags=$most_hostflags
+  done
 }


> Also, I think it could do with some adjustment of the column of the \s
> so that it doesn't get wrap damage when quoted.
> 

Will do.

Wei.

> I think we're going to be relying on the runvars diff in your 0/9 for
> properly checking that this all DTRT.
> 
> Thanks.
> Ian.